linux-kernel - Re: [PATCH] mm/page_isolation: fix clang deadcode warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6ea49a8-2ad2-1a80-a6f6-fe2d9b30f5b6@quicinc.com>
Date:   Fri, 21 Oct 2022 13:21:02 +0800
From:   "Aiqun(Maria) Yu" <quic_aiquny@...cinc.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     Matthew Wilcox <willy@...radead.org>, <ziy@...dia.com>,
        <david@...hat.com>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>, <mike.kravetz@...cle.com>,
        <opendmb@...il.com>
Subject: Re: [PATCH] mm/page_isolation: fix clang deadcode warning

On 10/21/2022 12:17 PM, Andrew Morton wrote:
> On Fri, 21 Oct 2022 11:26:22 +0800 "Aiqun(Maria) Yu" <quic_aiquny@...cinc.com> wrote:
> 
>>> Honestly, the cure is worse than the disease.  I'd rather not have a
>>> line that's this long.
>> I don't like this long either. While the current Deadcode warning is
>> also annoying for our clang tidy check.
>>
>> will the CONFIG check can be acceptable?
>> like:
>> 	#ifdef CONFIG_DEBUG_VM
>> or
>> 	if (IS_ENABLED(CONFIG_DEBUG_VM))
>>
>> Any good ideas?
> 
> Put a newline in there?
> 
> Although the shortly following lines are nearly as long...
> 
Thx for the suggestion. new patchset uploaded.

-- 
Thx and BRs,
Aiqun(Maria) Yu