linux-kernel - Re: [PATCH v4 11/11] staging: r8188eu: Remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1I0dcZqMJAzHSm2@kroah.com>
Date:   Fri, 21 Oct 2022 07:56:05 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Praveen Kumar <kumarpraveen@...ux.microsoft.com>
Cc:     Deepak R Varma <drv@...lo.com>, outreachy@...ts.linux.dev,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        paskripkin@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, saurabh.truth@...il.com
Subject: Re: [PATCH v4 11/11] staging: r8188eu: Remove unused macros

On Fri, Oct 21, 2022 at 11:21:06AM +0530, Praveen Kumar wrote:
> On 21-10-2022 03:02, Deepak R Varma wrote:
> > Simple variants of macros PlatformEFIOWrite and PlatformEFIORead are
> > defined but never used. As they do not appear to be designed for anything
> > significant, we can remove them to avoid unexpected usage.
> > 
> > Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
> > Signed-off-by: Deepak R Varma <drv@...lo.com>
> > ---
> > 
> > Changes in v4:
> >    1. Patch newly added to the patch set.
> > 
> > 
> >  drivers/staging/r8188eu/include/rtw_io.h | 14 --------------
> >  1 file changed, 14 deletions(-)
> > 
> > diff --git a/drivers/staging/r8188eu/include/rtw_io.h b/drivers/staging/r8188eu/include/rtw_io.h
> > index 87fcf6c94ff3..e9744694204b 100644
> > --- a/drivers/staging/r8188eu/include/rtw_io.h
> > +++ b/drivers/staging/r8188eu/include/rtw_io.h
> > @@ -285,18 +285,4 @@ void bus_sync_io(struct io_queue *pio_q);
> >  u32 _ioreq2rwmem(struct io_queue *pio_q);
> >  void dev_power_down(struct adapter *Adapter, u8 bpwrup);
> > 
> > -#define PlatformEFIOWrite1Byte(_a, _b, _c)		\
> > -	rtw_write8(_a, _b, _c)
> > -#define PlatformEFIOWrite2Byte(_a, _b, _c)		\
> > -	rtw_write16(_a, _b, _c)
> > -#define PlatformEFIOWrite4Byte(_a, _b, _c)		\
> > -	rtw_write32(_a, _b, _c)
> > -
> > -#define PlatformEFIORead1Byte(_a, _b)		\
> 
> Can the naming be reworked to make more Linux friendly ? something like PLATFORM_EFIO_READ1BYTE or better if there are other suggestions?
> Rest others as applicable ?

All of these should just be removed entirely and the normal calls here
made instead.  There is no need for these #defines at all.

thanks,

greg k-h