linux-kernel - Re: Request for assistance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHJEyKU7dH6HQW4rrd3gq5pnYUxOA0MGRUqtnC_yExt3PBok1g@mail.gmail.com>
Date:   Fri, 21 Oct 2022 07:11:01 +0100
From:   Tanju Brunostar <tanjubrunostar0@...il.com>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>,
        "Theodore Ts'o" <tytso@....edu>,
        Greg KH <gregkh@...uxfoundation.org>,
        Tanju Brunostar <tanjubrunostar0@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        outreachy@...ts.linux.dev
Subject: Re: Request for assistance

On Fri, Oct 21, 2022 at 12:38 AM Bhaskar Chowdhury
<unixbhaskar@...il.com> wrote:
>
> On 10:39 Thu 20 Oct 2022, Theodore Ts'o wrote:
> >Tanju, some additional hints.  First of all, please don't send cleanup
> >patches to address checkpatch --file complaints about overly long
> >lines.  It's generally not worth the code churn.
> >
> >Secondly for code that *you* are writing, think about why you have
> >lines which are exceeding the line width in the first place.  Is it
> >because code is being nested too deeply, and perhaps some judicious
> >function refactoring with good function names might make the code
> >clearer?  Would adding some temporary variables that are judiciously
> >named make the code look clearer?
> >
> >The rules about "thou shalt never have lines which exceed 78
> >characters" are rules of thumb.  The high level goal is to make the
> >code more readable and easier to understand, since good code is
> >maintainable code.  And sometimes it's not just about where to split
> >lines of code but whether there is a better way to structure the code
> >so that long lines aren't needed in the first place.
> >
> >Cheers,
> >
> >                                       - Ted
> Righto!! I failed to miss it my replies. That an editor can be trained or
> customized to that way. Especially , vim and emacs.
> --
> Thanks,
> Bhaskar
>
> "Here's looking at you kid"-- Casablanca
> https://about.me/unixbhaskar
I appreciate all your replies. They have been quite helpful. I will
try to apply them as I continue on my journey of contributing to the
kernel