linux-kernel - Re: [PATCH 13/17] ARM: omap1: remove unused board files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <de36ec6b-2e7c-48eb-9682-f60d8e4011da@app.fastmail.com>
Date:   Fri, 21 Oct 2022 08:52:10 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Aaro Koskinen" <aaro.koskinen@....fi>
Cc:     "Arnd Bergmann" <arnd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        "Janusz Krzysztofik" <jmkrzyszt@...il.com>,
        "Tony Lindgren" <tony@...mide.com>, linux-kernel@...r.kernel.org,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "Lee Jones" <lee@...nel.org>,
        "Ulf Hansson" <ulf.hansson@...aro.org>,
        "Felipe Balbi" <balbi@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        linux-i2c@...r.kernel.org,
        "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 13/17] ARM: omap1: remove unused board files

On Thu, Oct 20, 2022, at 21:35, Aaro Koskinen wrote:
> On Thu, Oct 20, 2022 at 09:11:11AM +0200, Arnd Bergmann wrote:
>> On Wed, Oct 19, 2022, at 19:15, Aaro Koskinen wrote:
>> > On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
>> >> All board support that was marked as 'unused' earlier can
>> >> now be removed, leaving the five machines that that still
>> >> had someone using them in 2022, or that are supported in
>> >> qemu.
>> > [...]
>> >>  config OMAP_OSK_MISTRAL
>> >>  	bool "Mistral QVGA board Support"
>> >>  	depends on MACH_OMAP_OSK
>> >> -	depends on UNUSED_BOARD_FILES
>> >>  	help
>> >>  	  The OSK supports an optional add-on board with a Quarter-VGA
>> >>  	  touchscreen, PDA-ish buttons, a resume button, bicolor LED,
>> >>  	  and camera connector.  Say Y here if you have this board.
>> >
>> > Shouldn't this go away as well?
>> 
>> No, this one was incorrectly annotated, it's not actually
>> a board but it's an option for the OSK board that is not
>> getting removed. I considered making a separate patch
>> for removing the dependency, but that didn't seem worth it.
>
> OK. For the record, I don't think anyone has this add-on board anymore,
> and it has probably never been tested with the mainline kernel, so
> it's likely in the "dead code" category... Maybe it could be changed to
> "BROKEN", then the related OSK LCD panel stuff could be deleted later
> on too.

Ok, good to know. I left it in place for now because Tony originally
listed it as a likely used machine along with NOKIA770 and
AMS_DELTA [1], but I don't have anyone listed specifically as a
user for it.

It's not too late to revisit this list if you think it helps to
get rid of it. I can see that drivers/mtd/tps65010.c and
drivers/pcmcia/omap_cf.c become orphaned without it and can
probably get removed as well then.

      Arnd

[1] https://lore.kernel.org/linux-arm-kernel/20220721150320.GA9385@macbook.musicnaut.iki.fi/