linux-kernel - Re: [PATCH v2 2/2] Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7383e705-6b8a-9e3e-ee94-6c59d8173779@amd.com>
Date:   Fri, 21 Oct 2022 09:21:54 +0200
From:   Michal Simek <michal.simek@....com>
To:     Rob Herring <robh@...nel.org>,
        Sai Krishna Potthuri <sai.krishna.potthuri@....com>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <saikrishna12468@...il.com>, <git@....com>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] Revert "dt-bindings: pinctrl-zynqmp: Add
 output-enable configuration"

Hi Rob,

On 10/21/22 03:11, Rob Herring wrote:
> On Mon, Oct 17, 2022 at 06:33:03PM +0530, Sai Krishna Potthuri wrote:
>> This reverts commit 133ad0d9af99bdca90705dadd8d31c20bfc9919f.
>>
>> On systems with older PMUFW (Xilinx ZynqMP Platform Management Firmware)
>> using these pinctrl properties can cause system hang because there is
>> missing feature autodetection.
>> When this feature is implemented, support for these two properties should
>> bring back.
> 
> So I'm going to get to review the revert of the revert at some point?
> Why do the properties need to be removed from the binding? They work on
> 'not older' firmware, right? Isn't just removing the driver support or
> removing from .dts files enough?

Removing functionality should be IMHO enough. Maybe make sense to inform users 
that there is missing functionality where they define these properties via DT.

Thanks,
Michal