linux-kernel - Re: [PATCH 1/2] drivers: rtc: add max313xx series rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210211648.W7uJkAgl-lkp@intel.com>
Date:   Fri, 21 Oct 2022 16:34:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ibrahim Tilki <Ibrahim.Tilki@...log.com>, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, jdelvare@...e.com,
        linux@...ck-us.net, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        Zeynep Arslanbenzer <Zeynep.Arslanbenzer@...log.com>
Subject: Re: [PATCH 1/2] drivers: rtc: add max313xx series rtc driver

Hi Ibrahim,

I love your patch! Perhaps something to improve:

[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on linus/master v6.1-rc1 next-20221020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ibrahim-Tilki/drivers-rtc-add-max313xx-series-rtc-driver/20221020-092245
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link:    https://lore.kernel.org/r/20221019133910.282-1-Ibrahim.Tilki%40analog.com
patch subject: [PATCH 1/2] drivers: rtc: add max313xx series rtc driver
config: x86_64-allmodconfig
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/574101d9954e99e957cf85c7f0b1eaf8d3dfe015
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ibrahim-Tilki/drivers-rtc-add-max313xx-series-rtc-driver/20221020-092245
        git checkout 574101d9954e99e957cf85c7f0b1eaf8d3dfe015
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ drivers/rtc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/rtc/rtc-max313xx.c:656:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           default:
           ^
   drivers/rtc/rtc-max313xx.c:656:2: note: insert 'break;' to avoid fall-through
           default:
           ^
           break; 
>> drivers/rtc/rtc-max313xx.c:1139:18: warning: cast to smaller integer type 'enum max313xx_ids' from 'const void *' [-Wvoid-pointer-to-enum-cast]
                   max313xx->id = (enum max313xx_ids)match;
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +656 drivers/rtc/rtc-max313xx.c

   642	
   643	static void max313xx_clkout_disable(struct clk_hw *hw)
   644	{
   645		struct max313xx *rtc = clk_hw_to_max313xx(hw);
   646		struct clkout_cfg *clkout = rtc->chip->clkout;
   647	
   648		switch (rtc->id) {
   649		case ID_MAX31331:
   650		case ID_MAX31334:
   651			if (rtc->irq > 0) {
   652				dev_err(rtc->rtc->dev.parent,
   653					"clkout cannot be disabled when IRQ is requested");
   654				return;
   655			}
 > 656		default:
   657			break;
   658		}
   659	
   660		if (clkout->en_invert)
   661			regmap_set_bits(rtc->regmap, clkout->reg, clkout->en_bit);
   662		else
   663			regmap_clear_bits(rtc->regmap, clkout->reg,  clkout->en_bit);
   664	}
   665	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (284810 bytes)