linux-kernel - Re: [PATCH v2 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1J/A//it5SeNKeL@gondor.apana.org.au>
Date:   Fri, 21 Oct 2022 19:14:11 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     'Guanjun' <guanjun@...ux.alibaba.com>
Cc:     elliott@....com, zelin.deng@...ux.alibaba.com,
        xuchun.shang@...ux.alibaba.com, artie.ding@...ux.alibaba.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex)
 accelerator driver

On Wed, Sep 28, 2022 at 03:37:59PM +0800, 'Guanjun' wrote:
>
> diff --git a/drivers/crypto/ycc/Makefile b/drivers/crypto/ycc/Makefile
> new file mode 100644
> index 00000000..7065273
> --- /dev/null
> +++ b/drivers/crypto/ycc/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-(CONFIG_CRYPTO_DEV_YCC) += ycc.o
> +ycc-objs := ycc_drv.o ycc_isr.o

This doesn't even compile.  When I fixed that it generates loads
of warnings with sparse turned on.  Please fix them all before you
resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt