[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y1KDtUdjmEVRKPt9@gondor.apana.org.au>
Date: Fri, 21 Oct 2022 19:34:13 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Natalia Petrova <n.petrova@...tech.ru>
Cc: "David S. Miller" <davem@...emloft.net>,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
ldv-project@...uxtesting.org,
Alexey Khoroshilov <khoroshilov@...ras.ru>
Subject: Re: [PATCH] nitrox: avoid double free on error path in
nitrox_sriov_init()
On Wed, Sep 28, 2022 at 01:25:05PM +0300, Natalia Petrova wrote:
> If alloc_workqueue() fails in nitrox_mbox_init() it deallocates
> ndev->iov.vfdev and returns error code, but then nitrox_sriov_init()
> calls nitrox_sriov_cleanup() where ndev->iov.vfdev is deallocated
> again.
>
> Fix this by nulling ndev->iov.vfdev after the first deallocation.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Natalia Petrova <n.petrova@...tech.ru>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> ---
> drivers/crypto/cavium/nitrox/nitrox_mbx.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists