linux-kernel - RE: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR12MB3895DCAC7DEF7085633C51C9D72D9@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Fri, 21 Oct 2022 12:43:21 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Wolfram Sang <wsa@...nel.org>, Adam Borowski <kilobyte@...band.pl>
CC:     Khalil Blaiech <kblaiech@...dia.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage

LGTM. Thanks Wolfram!
Acked-By: Asmaa Mnebhi <asmaa@...dia.com>

-----Original Message-----
From: Wolfram Sang <wsa@...nel.org> 
Sent: Friday, October 21, 2022 2:43 AM
To: Adam Borowski <kilobyte@...band.pl>
Cc: Khalil Blaiech <kblaiech@...dia.com>; Asmaa Mnebhi <asmaa@...dia.com>; linux-i2c@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage

On Mon, Oct 10, 2022 at 08:33:51PM +0200, Adam Borowski wrote:
> This fixes maybe_unused warnings/errors.
> 
> According to a comment during device tree removal, only ACPI is 
> supported, thus let's actually require it.
> 
> Fixes: be18c5ede25da39a0eda541f6de3620a30cf731f
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>

Applied to for-current, thanks!

@Asmaa, @Khalil: normally, I will not skip the driver maintainer's ack but wait for it. I'd like to make an exception this time because I don't want to get another dozen of patches fixing this build warning. Since Asmaa already acked a similar patch, I hope this is okay with you.