| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <78a117d5-b4be-8389-c909-9f8525b151d8@linaro.org>
Date: Fri, 21 Oct 2022 10:44:01 -0400
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Harry Austen <hpausten@...tonmail.com>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Yassine Oudjana <y.oudjana@...tonmail.com>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: msm8996: add support for
oneplus3(t)
On 21/10/2022 10:24, Harry Austen wrote:
> Add initial support for OnePlus 3 and 3T mobile phones. They are based
> on the MSM8996 SoC.
>
> Co-developed-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> Signed-off-by: Harry Austen <hpausten@...tonmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../boot/dts/qcom/msm8996-oneplus-common.dtsi | 794 ++++++++++++++++++
> arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts | 44 +
> .../arm64/boot/dts/qcom/msm8996-oneplus3t.dts | 45 +
> 4 files changed, 885 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index d7669a7cee9f..0380ac4fb196 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -33,6 +33,8 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8994-sony-xperia-kitakami-satsuki.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8994-sony-xperia-kitakami-sumire.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8994-sony-xperia-kitakami-suzuran.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-oneplus3.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-oneplus3t.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8996-sony-xperia-tone-dora.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8996-sony-xperia-tone-kagura.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8996-sony-xperia-tone-keyaki.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> new file mode 100644
> index 000000000000..41eb6f28e9a4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> @@ -0,0 +1,794 @@
> +// SPDX-License-Identifier: GPL-2.0-only
Are you sure this is GPL-2.0 only? Didn't you derive it from downstream
OnePlus DTS?
> +/*
> + * Copyright (c) 2022, The Linux Foundation. All rights reserved.
> + */
> +
> +#include "msm8996.dtsi"
> +#include "pm8994.dtsi"
> +#include "pmi8994.dtsi"
> +#include "pmi8996.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> +#include <dt-bindings/sound/qcom,q6asm.h>
> +#include <dt-bindings/sound/qcom,wcd9335.h>
> +
> +/ {
> + aliases {
> + serial0 = &blsp1_uart2;
> + serial1 = &blsp2_uart2;
> + };
> +
> + battery: battery {
> + compatible = "simple-battery";
> +
> + constant-charge-current-max-microamp = <3000000>;
> + voltage-min-design-microvolt = <3400000>;
> + };
> +
> + chosen {
> + stdout-path = "serial1:115200n8";
> + };
> +
> + clocks {
> + compatible = "simple-bus";
This is not a bus of clocks...
> +
> + divclk4: divclk4 {
Use common suffix or prefix for node names and generic name.
This clock is anyway a bit weird - same frequency as sleep clk.
> + compatible = "fixed-clock";
> + pinctrl-names = "default";
> + pinctrl-0 = <&divclk4_pin_a>;
This is a PMIC pin? So is it a PMIC clk?
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + clock-output-names = "divclk4";
> + };
> +
> + div1_mclk: divclk1 {
> + compatible = "gpio-gate-clock";
> + pinctrl-names = "default";
> + pinctrl-0 = <&audio_mclk>;
> + #clock-cells = <0>;
> + clocks = <&rpmcc RPM_SMD_DIV_CLK1>;
> + enable-gpios = <&pm8994_gpios 15 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> + reserved-memory {
> + ramoops@...00000 {
> + compatible = "ramoops";
> + reg = <0 0xac000000 0 0x200000>;
> + record-size = <0x20000>;
> + console-size = <0x100000>;
> + pmsg-size = <0x80000>;
> + };
> + };
> +
> + vph_pwr: vph-pwr-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + wlan_en: wlan-en-1-8v {
Use common suffix or prefix. You already used "-regulator" suffix before.
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&wlan_en_gpios>;
> + regulator-name = "wlan-en-regulator";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + gpio = <&pm8994_gpios 8 GPIO_ACTIVE_HIGH>;
> +
> + /* WLAN card specific delay */
> + startup-delay-us = <70000>;
> + enable-active-high;
> + };
> +};
> +
> +&adsp_pil {
> + status = "okay";
> +};
> +
> +&blsp1_i2c3 {
> + status = "okay";
> +
> + tfa9890_amp: audio-codec@36 {
> + compatible = "nxp,tfa9890";
> + reg = <0x36>;
> + #sound-dai-cells = <0>;
> + };
> +};
> +
> +&blsp1_i2c6 {
> + status = "okay";
> +
> + bq27541: fuel-gauge@55 {
> + compatible = "ti,bq27541";
> + reg = <0x55>;
> + };
> +};
> +
> +&blsp1_uart2 {
> + label = "BT-UART";
> + status = "okay";
Status is a last property.
> + uart-has-rtscts;
> +
> + bluetooth {
> + compatible = "qcom,qca6174-bt";
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en_gpios>;
> + enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
> + clocks = <&divclk4>;
> + };
> +};
> +
> +&blsp2_i2c1 {
> + status = "okay";
> +};
> +
> +&blsp2_i2c6 {
> + status = "okay";
> +
> + synaptics_rmi4_i2c: touchscreen@20 {
> + compatible = "syna,rmi4-i2c";
> + reg = <0x20>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts-extended = <&tlmm 125 IRQ_TYPE_EDGE_FALLING>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&touch_default>;
> + pinctrl-1 = <&touch_suspend>;
> + vdd-supply = <&vreg_l22a_3p0>;
> + vio-supply = <&vreg_s4a_1p8>;
> + syna,reset-delay-ms = <200>;
> + syna,startup-delay-ms = <200>;
> +
> + rmi4-f01@1 {
> + reg = <0x1>;
> + syna,nosleep-mode = <1>;
> + };
> +
> + rmi4-f12@12 {
> + reg = <0x12>;
> + syna,sensor-type = <1>;
> + touchscreen-x-mm = <68>;
> + touchscreen-y-mm = <122>;
> + };
> + };
> +};
> +
> +&blsp2_uart2 {
> + status = "okay";
Status is last.
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&blsp2_uart2_2pins_default>;
> + pinctrl-1 = <&blsp2_uart2_2pins_sleep>;
> +};
> +
> +&camss {
> + vdda-supply = <&vreg_l2a_1p25>;
> +};
> +
> +&dsi0 {
> + status = "okay";
And so on...
> +
> + vdda-supply = <&vreg_l2a_1p25>;
> + vcca-supply = <&vreg_l22a_3p0>;
> +};
Best regards,
Krzysztof
Powered by blists - more mailing lists