linux-kernel - Re: [PATCH v2 2/2] KVM: debugfs: Return retval of simple_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9327f38-72b3-bf65-a318-bf5982364c15@redhat.com>
Date:   Sat, 22 Oct 2022 11:08:58 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Hou Wenlong <houwenlong.hwl@...group.com>, kvm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] KVM: debugfs: Return retval of simple_attr_open()
 if it fails

On 10/17/22 05:06, Hou Wenlong wrote:
> Although simple_attr_open() fails only with -ENOMEM with current code
> base, it would be nicer to return retval of simple_attr_open() directly
> in kvm_debugfs_open().
> 
> No functional change intended.
> 
> Signed-off-by: Hou Wenlong <houwenlong.hwl@...group.com>
> ---
>   virt/kvm/kvm_main.c | 13 ++++++-------
>   1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index e30f1b4ecfa5..f7b06c1e8827 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -5398,6 +5398,7 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file,
>   			   int (*get)(void *, u64 *), int (*set)(void *, u64),
>   			   const char *fmt)
>   {
> +	int ret;
>   	struct kvm_stat_data *stat_data = (struct kvm_stat_data *)
>   					  inode->i_private;
>   
> @@ -5409,15 +5410,13 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file,
>   	if (!kvm_get_kvm_safe(stat_data->kvm))
>   		return -ENOENT;
>   
> -	if (simple_attr_open(inode, file, get,
> -		    kvm_stats_debugfs_mode(stat_data->desc) & 0222
> -		    ? set : NULL,
> -		    fmt)) {
> +	ret = simple_attr_open(inode, file, get,
> +			       kvm_stats_debugfs_mode(stat_data->desc) & 0222
> +			       ? set : NULL, fmt);
> +	if (ret)
>   		kvm_put_kvm(stat_data->kvm);
> -		return -ENOMEM;
> -	}
>   
> -	return 0;
> +	return ret;
>   }
>   
>   static int kvm_debugfs_release(struct inode *inode, struct file *file)

Queued, thanks.

Paolo