lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 22 Oct 2022 19:00:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lijo Lazar <lijo.lazar@....com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>,
        Guchun Chen <guchun.chen@....com>
Subject: [agd5f:drm-next 41/66]
 drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:686:3: warning: variable 'data' is
 uninitialized when used here

tree:   https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head:   fb5e487f910e1105019b883e8ed25e36e4bfd657
commit: 7a4fad619819f62fad155d11e602ee3093f75d2c [41/66] drm/amdgpu: Remove ATC L2 access for MMHUB 2.1.x
config: s390-randconfig-r024-20221019
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install s390 cross compiling tool for clang build
        # apt-get install binutils-s390x-linux-gnu
        git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
        git fetch --no-tags agd5f drm-next
        git checkout 7a4fad619819f62fad155d11e602ee3093f75d2c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:24:
   In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:52:
   In file included from include/linux/pci.h:39:
   In file included from include/linux/io.h:13:
   In file included from arch/s390/include/asm/io.h:75:
   include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __raw_readb(PCI_IOBASE + addr);
                             ~~~~~~~~~~ ^
   include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
                                                           ~~~~~~~~~~ ^
   include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
   #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
                                                             ^
   include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
   #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
                                                        ^
   In file included from drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:24:
   In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:52:
   In file included from include/linux/pci.h:39:
   In file included from include/linux/io.h:13:
   In file included from arch/s390/include/asm/io.h:75:
   include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
                                                           ~~~~~~~~~~ ^
   include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
   #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
                                                             ^
   include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
   #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
                                                        ^
   In file included from drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:24:
   In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:52:
   In file included from include/linux/pci.h:39:
   In file included from include/linux/io.h:13:
   In file included from arch/s390/include/asm/io.h:75:
   include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           __raw_writeb(value, PCI_IOBASE + addr);
                               ~~~~~~~~~~ ^
   include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
                                                         ~~~~~~~~~~ ^
   include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
                                                         ~~~~~~~~~~ ^
   include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           readsb(PCI_IOBASE + addr, buffer, count);
                  ~~~~~~~~~~ ^
   include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           readsw(PCI_IOBASE + addr, buffer, count);
                  ~~~~~~~~~~ ^
   include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           readsl(PCI_IOBASE + addr, buffer, count);
                  ~~~~~~~~~~ ^
   include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           writesb(PCI_IOBASE + addr, buffer, count);
                   ~~~~~~~~~~ ^
   include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           writesw(PCI_IOBASE + addr, buffer, count);
                   ~~~~~~~~~~ ^
   include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           writesl(PCI_IOBASE + addr, buffer, count);
                   ~~~~~~~~~~ ^
>> drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:686:3: warning: variable 'data' is uninitialized when used here [-Wuninitialized]
                   data |= MM_ATC_L2_MISC_CG__ENABLE_MASK;
                   ^~~~
   drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:674:10: note: initialize the variable 'data' to silence this warning
           int data, data1;
                   ^
                    = 0
   13 warnings generated.


vim +/data +686 drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c

   671	
   672	static void mmhub_v2_0_get_clockgating(struct amdgpu_device *adev, u64 *flags)
   673	{
   674		int data, data1;
   675	
   676		if (amdgpu_sriov_vf(adev))
   677			*flags = 0;
   678	
   679		switch (adev->ip_versions[MMHUB_HWIP][0]) {
   680		case IP_VERSION(2, 1, 0):
   681		case IP_VERSION(2, 1, 1):
   682		case IP_VERSION(2, 1, 2):
   683			/* There is no ATCL2 in MMHUB for 2.1.x. Keep the status
   684			 * based on DAGB
   685			 */
 > 686			data |= MM_ATC_L2_MISC_CG__ENABLE_MASK;
   687			data1 = RREG32_SOC15(MMHUB, 0, mmDAGB0_CNTL_MISC2_Sienna_Cichlid);
   688			break;
   689		default:
   690			data  = RREG32_SOC15(MMHUB, 0, mmMM_ATC_L2_MISC_CG);
   691			data1 = RREG32_SOC15(MMHUB, 0, mmDAGB0_CNTL_MISC2);
   692			break;
   693		}
   694	
   695		/* AMD_CG_SUPPORT_MC_MGCG */
   696		if ((data & MM_ATC_L2_MISC_CG__ENABLE_MASK) &&
   697		    !(data1 & (DAGB0_CNTL_MISC2__DISABLE_WRREQ_CG_MASK |
   698			       DAGB0_CNTL_MISC2__DISABLE_WRRET_CG_MASK |
   699			       DAGB0_CNTL_MISC2__DISABLE_RDREQ_CG_MASK |
   700			       DAGB0_CNTL_MISC2__DISABLE_RDRET_CG_MASK |
   701			       DAGB0_CNTL_MISC2__DISABLE_TLBWR_CG_MASK |
   702			       DAGB0_CNTL_MISC2__DISABLE_TLBRD_CG_MASK)))
   703			*flags |= AMD_CG_SUPPORT_MC_MGCG;
   704	
   705		/* AMD_CG_SUPPORT_MC_LS */
   706		if (data & MM_ATC_L2_MISC_CG__MEM_LS_ENABLE_MASK)
   707			*flags |= AMD_CG_SUPPORT_MC_LS;
   708	}
   709	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (142791 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ