linux-kernel - Re: [PATCH v2] counter: microchip-tcb-capture: Handle Signal1 read and Synapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Oct 2022 11:11:12 -0400
From:   William Breathitt Gray <wbg@...nel.org>
To:     William Breathitt Gray <william.gray@...aro.org>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, stable@...r.kernel.org,
        Kamel Bouhara <kamel.bouhara@...tlin.com>
Subject: Re: [PATCH v2] counter: microchip-tcb-capture: Handle Signal1 read
 and Synapse

On Tue, Oct 18, 2022 at 08:10:14AM -0400, William Breathitt Gray wrote:
> The signal_read(), action_read(), and action_write() callbacks have been
> assuming Signal0 is requested without checking. This results in requests
> for Signal1 returning data for Signal0. This patch fixes these
> oversights by properly checking for the Signal's id in the respective
> callbacks and handling accordingly based on the particular Signal
> requested. The trig_inverted member of the mchp_tc_data is removed as
> superfluous.
> 
> Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> Cc: stable@...r.kernel.org
> Cc: Kamel Bouhara <kamel.bouhara@...tlin.com>
> Signed-off-by: William Breathitt Gray <william.gray@...aro.org>
> ---
> Changes in v2:
>  - Simplified action_read() changes to just handle qdec_mode and
>    non-TIOA Signals before continuing with existing code

Queued for counter-fixes.

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)