linux-kernel - Re: [PATCH] staging: vchiq: add 'static' to function definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 02:04:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Scott J. Crouch" <scottjcrouch@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kbuild-all@...ts.01.org, kernel-janitors@...r.kernel.org,
        "Scott J. Crouch" <scottjcrouch@...il.com>,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vchiq: add 'static' to function definition

Hi Scott,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Scott-J-Crouch/staging-vchiq-add-static-to-function-definition/20221022-123712
patch link:    https://lore.kernel.org/r/20221022043548.1671644-1-scottjcrouch%40gmail.com
patch subject: [PATCH] staging: vchiq: add 'static' to function definition
config: ia64-randconfig-s043-20221019
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/212f23023953af62f30dfa46cae6ed350f72e798
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Scott-J-Crouch/staging-vchiq-add-static-to-function-definition/20221022-123712
        git checkout 212f23023953af62f30dfa46cae6ed350f72e798
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/staging/vc04_services/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:16:
   In function 'memcpy_to_page',
       inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:433:4:
>> include/linux/highmem.h:377:9: warning: argument 2 null where non-null expected [-Wnonnull]
     377 |         memcpy(to + offset, from, len);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/string.h:20,
                    from include/linux/bitmap.h:11,
                    from include/linux/cpumask.h:12,
                    from include/linux/mm_types_task.h:14,
                    from include/linux/mm_types.h:5,
                    from include/linux/buildid.h:5,
                    from include/linux/module.h:14,
                    from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:8:
   arch/ia64/include/asm/string.h: In function 'free_pagelist':
   arch/ia64/include/asm/string.h:19:14: note: in a call to function 'memcpy' declared 'nonnull'
      19 | extern void *memcpy (void *, const void *, __kernel_size_t);
         |              ^~~~~~
   In function 'memcpy_to_page',
       inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:440:4:
>> include/linux/highmem.h:377:9: warning: 'memcpy' reading between 1 and 31 bytes from a region of size 0 [-Wstringop-overread]
     377 |         memcpy(to + offset, from, len);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +377 include/linux/highmem.h

bb90d4bc7b6a53 Ira Weiny         2021-02-09  370  
bb90d4bc7b6a53 Ira Weiny         2021-02-09  371  static inline void memcpy_to_page(struct page *page, size_t offset,
bb90d4bc7b6a53 Ira Weiny         2021-02-09  372  				  const char *from, size_t len)
bb90d4bc7b6a53 Ira Weiny         2021-02-09  373  {
61b205f579911a Ira Weiny         2021-02-09  374  	char *to = kmap_local_page(page);
bb90d4bc7b6a53 Ira Weiny         2021-02-09  375  
ca18f6ea012bf3 Ira Weiny         2021-02-10  376  	VM_BUG_ON(offset + len > PAGE_SIZE);
bb90d4bc7b6a53 Ira Weiny         2021-02-09 @377  	memcpy(to + offset, from, len);
8dad53a11f8d94 Christoph Hellwig 2021-07-23  378  	flush_dcache_page(page);
61b205f579911a Ira Weiny         2021-02-09  379  	kunmap_local(to);
bb90d4bc7b6a53 Ira Weiny         2021-02-09  380  }
bb90d4bc7b6a53 Ira Weiny         2021-02-09  381  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (149310 bytes)