linux-kernel - Re: [PATCH v2 4/6] staging: vt6655: refactor long lines of code in s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHJEyKWZxU783o=D0n_Gy0Vxn37t5DGt48VX9yQTLaRpyYpPsQ@mail.gmail.com>
Date:   Sat, 22 Oct 2022 06:49:15 +0100
From:   Tanju Brunostar <tanjubrunostar0@...il.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH v2 4/6] staging: vt6655: refactor long lines of code in s_vGenerateTxParameter

On Sat, Oct 22, 2022 at 5:39 AM Philipp Hortmann
<philipp.g.hortmann@...il.com> wrote:
>
> On 10/21/22 20:14, Tanju Brunostar wrote:
> >>> Error during compiliation in next line
> >>>
> >>>> +                     struct vnt_rrv_time_ab *buf = pvRrvT
> >>>> +                             ime;
> >>> make: Entering directory '/home/kernel/Documents/git/kernels/staging'
> >>>     CC [M]  drivers/staging/vt6655/rxtx.o
> >>> drivers/staging/vt6655/rxtx.c: In function ‘s_vGenerateTxParameter’:
> >>> drivers/staging/vt6655/rxtx.c:1014:34: error: ‘pvRrvT’ undeclared (first
> >>> use in this function)
> >>>    1014 |    struct vnt_rrv_time_ab *buf = pvRrvT
> >>>         |                                  ^~~~~~
> >>> drivers/staging/vt6655/rxtx.c:1014:34: note: each undeclared identifier
> >>> is reported only once for each function it appears in
> >>> drivers/staging/vt6655/rxtx.c:1015:5: error: expected ‘,’ or ‘;’ before
> >>> ‘ime’
> >>>    1015 |     ime;
> >>>         |     ^~~
> >>> make[1]: *** [scripts/Makefile.build:250: drivers/staging/vt6655/rxtx.o]
> >>> Error 1
> >>> make: *** [Makefile:1992: drivers/staging/vt6655] Error 2
> >>> make: Leaving directory '/home/kernel/Documents/git/kernels/staging'
> >>>
> >> This error occured on the first version of this patch. I corrected it,
> >> compiled the code and the error was gone before I sent this version.
> >> please check again. You may have seen this error on the first version
> >> and not this one.
> >> thanks
> >>
> >> Tanju
> > On the first patch, this error was detected by the kernel bot. This
> > time around, the kernel bot did not detect it, meaning it was fixed.
>
> Please check the outbox of your email account and have a look. This is
> the v2 Patch and it contains this two lines:
>  >>>> +                     struct vnt_rrv_time_ab *buf = pvRrvT
>  >>>> +                             ime;
> which do not compile.
>
> Bye Philipp
Oh you are right. I don't know how this is possible. I will send a
third version.