linux-kernel - Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Oct 2022 08:35:18 +0100
From:   Tanju Brunostar <tanjubrunostar0@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '('

On Sat, Oct 22, 2022 at 8:18 AM Joe Perches <joe@...ches.com> wrote:
>
> On Sat, 2022-10-22 at 07:06 +0000, Tanjuate Brunostar wrote:
> > fix serveral checkpatch errors related to lines ending with a '(' by
> > refactoring the code lines
> []
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> []
> > @@ -141,13 +141,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> >   */
> >  static
> >  unsigned int
> > -s_uGetTxRsvTime(
> > -     struct vnt_private *pDevice,
> > -     unsigned char byPktType,
> > -     unsigned int cbFrameLength,
> > -     unsigned short wRate,
> > -     bool bNeedAck
> > -)
> > +s_uGetTxRsvTime(struct vnt_private *pDevice,
>
> If you end up doing more work here, ou might consider removing the
> Hungarian style notations
>
> Maybe something like:
>
> s_uGetTxRsvTime -> get_tx_rsv_time
>
> > +             unsigned char byPktType,
>
> byPktType       -> pkt_type
>
> etc...
>
> Perhaps patches by unique rename.
>
Yes I plan on doing that as a separate patch. It could be overwhelming
keeping track of so many changes at a time
thanks
Tanju