linux-kernel - Re: [PATCH -next] block: fix memory leak for elevator on add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <716cbd61-2567-5a02-59f1-936e0960077b@huaweicloud.com>
Date:   Sat, 22 Oct 2022 09:54:59 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Ming Lei <ming.lei@...hat.com>, Yu Kuai <yukuai1@...weicloud.com>
Cc:     hch@....de, axboe@...nel.dk, damien.lemoal@....com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH -next] block: fix memory leak for elevator on add_disk
 failure

在 2022/10/21 11:47, Ming Lei 写道:
> On Fri, Oct 21, 2022 at 11:39:50AM +0800, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@...wei.com>
>>
>> The default elevator is allocated in the begining of device_add_disk(),
>> however, it's not freed in the following error path.
>>
>> Fixes: 737eb78e82d5 ("block: Delay default elevator initialization")
> 
> Originally elevator can be teardown in disk release, or queue release
> earlier time, so the fixes tag should be:
> 
> Fixes: 50e34d78815e ("block: disable the elevator int del_gendisk")

You're right! Thanks for the notice, I'll send a new version.

Kuai
> 
> 
> Thanks,
> Ming
> 
> .
>