linux-kernel - Re: [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Oct 2022 10:05:36 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Deepak R Varma <drv@...lo.com>
Cc:     outreachy@...ts.linux.dev, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, paskripkin@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kumarpraveen@...ux.microsoft.com, saurabh.truth@...il.com
Subject: Re: [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches

On Fri, Oct 21, 2022 at 02:56:10AM +0530, Deepak R Varma wrote:
> Address different kinds of checkpatch complains for the staging/r8188eu module.
> The patches are required to be applied in sequence.
> 
> Changes in v4:
>    1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@...ia.fr
>    2. Update patch 1 per feedback from David.Laight@...LAB.COM
>    3. Update patch 5 & 6 per feedback from dan.carpenter@...cle.com & julia.lawall@...ia.fr
> 
> Changes in v3:
>    1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
>       This was suggested by philipp.g.hortmann@...il.com
>    2. Patch 4: Spelling mistake corrected as pointed out by joe@...ches.com
>    3. Patch 5 through 10: Included in this version. Additional clean up patches.
> 
> Changes in v2:
>    I incorrectly labeled the first revision as v1 instead of v2. So,
>    following change recorded under v1 is actually changes for v2. Feedback
>    provided by philipp.g.hortmann@...il.com
>       1. Improve language / grammar for the patch descriptions
>       2. Further improve code reformatting
> 

I've taken these, but note, your email system is not properly being
authenticated.  Here's the results I get when I use the tool 'b4' to
apply the patches:

Grabbing thread from lore.kernel.org/all/cover.1666299151.git.drv%40mailo.com/t.mbox.gz
Analyzing 20 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH v4 1/11] staging: r8188eu: use Linux kernel variable naming convention
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 2/11] staging: r8188eu: reformat long computation lines
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 3/11] staging: r8188eu: remove {} for single statement blocks
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 4/11] staging: r8188eu: use htons macro instead of __constant_htons
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 5/11] staging: r8188eu: correct misspelled words in comments
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 6/11] staging: r8188eu: Add space between function & macro parameters
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 7/11] staging: r8188eu: Associate pointer symbol with parameter name
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 8/11] staging: r8188eu: replace leading spaces by tabs
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 9/11] staging: r8188eu: Put '{" on the symbol declaration line
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 10/11] staging: r8188eu: Correct missing or extra space in the statements
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 11/11] staging: r8188eu: Remove unused macros
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> (✓ DKIM/gmail.com)
  ---
  ✗ BADSIG: DKIM/mailo.com
---
Total patches: 11


Please look into fixing up your DKIM settings.

thanks,

greg k-h