linux-kernel - Re: [PATCH v3 5/6] staging: vt6655: refactor long lines of code in the rest of the file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Oct 2022 10:14:59 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tanjuate Brunostar <tanjubrunostar0@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH v3 5/6] staging: vt6655: refactor long lines of code in
 the rest of the file

On Sat, Oct 22, 2022 at 07:06:11AM +0000, Tanjuate Brunostar wrote:
> fix checkpatch errors by refactoring long lines of code in the rest of
> the file
> 
> Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@...il.com>
> ---
>  drivers/staging/vt6655/rxtx.c | 105 ++++++++++++++++++++++------------
>  1 file changed, 67 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 951d4172e9f2..572be45cdbeb 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -1105,44 +1105,60 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
>  		if (byFBOption == AUTO_FB_NONE) {
>  			if (bRTS) {/* RTS_need */
>  				pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
> -				pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
> -				pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
> +				pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize +
> +					   sizeof(struct vnt_rrv_time_rts));
> +				pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize +
> +						 sizeof(struct vnt_rrv_time_rts) + cbMICHDR);

Casting to void * is very odd.  Try working on fixing up that mess
first...

thanks,

greg k-h