linux-kernel - [ammarfaizi2-block:brauner/linux/fs.vfsuid.conversion 3/8] kernel/capability.c:493 privileged_wrt_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 20:25:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christian Brauner <brauner@...nel.org>
Cc:     kbuild-all@...ts.01.org, Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:brauner/linux/fs.vfsuid.conversion 3/8]
 kernel/capability.c:493 privileged_wrt_inode_uidgid() warn: inconsistent
 indenting

tree:   https://github.com/ammarfaizi2/linux-block brauner/linux/fs.vfsuid.conversion
head:   8cd44fdee4fc058894f2472b637bbe3e0b897473
commit: 58c5d0b648a560cf0368286f7bac3729b92b1b2f [3/8] caps: use type safe idmapping helpers
config: parisc-randconfig-m031-20221023
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
kernel/capability.c:493 privileged_wrt_inode_uidgid() warn: inconsistent indenting
kernel/capability.c:493 privileged_wrt_inode_uidgid() warn: ignoring unreachable code.

vim +493 kernel/capability.c

   480	
   481	/**
   482	 * privileged_wrt_inode_uidgid - Do capabilities in the namespace work over the inode?
   483	 * @ns: The user namespace in question
   484	 * @inode: The inode in question
   485	 *
   486	 * Return true if the inode uid and gid are within the namespace.
   487	 */
   488	bool privileged_wrt_inode_uidgid(struct user_namespace *ns,
   489					 struct user_namespace *mnt_userns,
   490					 const struct inode *inode)
   491	{
   492		return vfsuid_has_mapping(ns, i_uid_into_vfsuid(mnt_userns, inode));
 > 493		       vfsgid_has_mapping(ns, i_gid_into_vfsgid(mnt_userns, inode));
   494	}
   495	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (129266 bytes)