linux-kernel - Re: [PATCH v3 2/2] serial: 8250/ingenic: Add support for the JZ4750/JZ4755

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKNVLfbJaGd0t==AzxyT5Q7fVD7PwK75-S5dbb+G9GZUPpagZQ@mail.gmail.com>
Date:   Sun, 23 Oct 2022 17:04:49 +0300
From:   Siarhei Volkau <lis8215@...il.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v3 2/2] serial: 8250/ingenic: Add support for the JZ4750/JZ4755

вс, 23 окт. 2022 г. в 12:16, Paul Cercueil <paul@...pouillou.net>:
> Do you have such hardware?

No

> Don't add support for cases you can't test.

It's just a side effect of that approach.

> For what we know - all JZ475x use a 24 MHz crystal and all JZ4760(B)
> use a 12 MHz crystal, until proven otherwise.

Ouf course it just confirms the rule but I found one exception: JZ4750 & 12MHz
Link: https://github.com/carlos-wong/uboot_jz4755/blob/master/include/configs/lib4750.h

Regarding your proposal:
In my opinion enabling the divisor unconditionally is a bad practice,
as it's already enabled (or not) by the bootloader, with respect to the
hardware capabilities.I think it's better to keep the driver as it is than
adding such things.

BR,
Siarhei