linux-kernel - Re: [PATCH v2] staging: wlan-ng: remove commented debug printk messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 16:13:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Deepak R Varma <drv@...lo.com>, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk
 messages

On Sun, Oct 23, 2022 at 08:35:47PM +0700, Bagas Sanjaya wrote:
> On Sat, Oct 22, 2022 at 01:03:42AM +0530, Deepak R Varma wrote:
> > diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> > index e04fc666d218..6bef419e8ad0 100644
> > --- a/drivers/staging/wlan-ng/p80211netdev.c
> > +++ b/drivers/staging/wlan-ng/p80211netdev.c
> > @@ -881,55 +881,42 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >  		wlandev->rx.mgmt++;
> >  		switch (fstype) {
> >  		case WLAN_FSTYPE_ASSOCREQ:
> > -			/* printk("assocreq"); */
> >  			wlandev->rx.assocreq++;
> >  			break;
> >  		case WLAN_FSTYPE_ASSOCRESP:
> > -			/* printk("assocresp"); */
> >  			wlandev->rx.assocresp++;
> >  			break;
> >  		case WLAN_FSTYPE_REASSOCREQ:
> > -			/* printk("reassocreq"); */
> >  			wlandev->rx.reassocreq++;
> >  			break;
> >  		case WLAN_FSTYPE_REASSOCRESP:
> > -			/* printk("reassocresp"); */
> >  			wlandev->rx.reassocresp++;
> >  			break;
> >  		case WLAN_FSTYPE_PROBEREQ:
> > -			/* printk("probereq"); */
> >  			wlandev->rx.probereq++;
> >  			break;
> >  		case WLAN_FSTYPE_PROBERESP:
> > -			/* printk("proberesp"); */
> >  			wlandev->rx.proberesp++;
> >  			break;
> >  		case WLAN_FSTYPE_BEACON:
> > -			/* printk("beacon"); */
> >  			wlandev->rx.beacon++;
> >  			break;
> >  		case WLAN_FSTYPE_ATIM:
> > -			/* printk("atim"); */
> >  			wlandev->rx.atim++;
> >  			break;
> >  		case WLAN_FSTYPE_DISASSOC:
> > -			/* printk("disassoc"); */
> >  			wlandev->rx.disassoc++;
> >  			break;
> >  		case WLAN_FSTYPE_AUTHEN:
> > -			/* printk("authen"); */
> >  			wlandev->rx.authen++;
> >  			break;
> >  		case WLAN_FSTYPE_DEAUTHEN:
> > -			/* printk("deauthen"); */
> >  			wlandev->rx.deauthen++;
> >  			break;
> >  		default:
> > -			/* printk("unknown"); */
> >  			wlandev->rx.mgmt_unknown++;
> >  			break;
> >  		}
> > -		/* printk("\n"); */
> >  		drop = 2;
> >  		break;
> > 
> > @@ -943,35 +930,27 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >  		wlandev->rx.ctl++;
> >  		switch (fstype) {
> >  		case WLAN_FSTYPE_PSPOLL:
> > -			/* printk("pspoll"); */
> >  			wlandev->rx.pspoll++;
> >  			break;
> >  		case WLAN_FSTYPE_RTS:
> > -			/* printk("rts"); */
> >  			wlandev->rx.rts++;
> >  			break;
> >  		case WLAN_FSTYPE_CTS:
> > -			/* printk("cts"); */
> >  			wlandev->rx.cts++;
> >  			break;
> >  		case WLAN_FSTYPE_ACK:
> > -			/* printk("ack"); */
> >  			wlandev->rx.ack++;
> >  			break;
> >  		case WLAN_FSTYPE_CFEND:
> > -			/* printk("cfend"); */
> >  			wlandev->rx.cfend++;
> >  			break;
> >  		case WLAN_FSTYPE_CFENDCFACK:
> > -			/* printk("cfendcfack"); */
> >  			wlandev->rx.cfendcfack++;
> >  			break;
> >  		default:
> > -			/* printk("unknown"); */
> >  			wlandev->rx.ctl_unknown++;
> >  			break;
> >  		}
> > -		/* printk("\n"); */
> >  		drop = 2;
> >  		break;
> > 
> > @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >  			wlandev->rx.cfack_cfpoll++;
> >  			break;
> >  		default:
> > -			/* printk("unknown"); */
> >  			wlandev->rx.data_unknown++;
> >  			break;
> >  		}
> 
> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?

No, they should just be removed as was done here.

thanks,

greg k-h