linux-kernel - [PATCH] serial: 8250_bcm2835aux: return PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 14:50:53 +0800
From:   Zeng Heng <zengheng4@...wei.com>
To:     <jirislaby@...nel.org>, <f.fainelli@...il.com>,
        <sbranden@...adcom.com>, <l.sanfilippo@...bus.com>,
        <guomengqi3@...wei.com>, <rjui@...adcom.com>,
        <ilpo.jarvinen@...ux.intel.com>, <zengheng4@...wei.com>,
        <bcm-kernel-feedback-list@...adcom.com>,
        <gregkh@...uxfoundation.org>, <athierry@...hat.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-rpi-kernel@...ts.infradead.org>, <liwei391@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>
Subject: [PATCH] serial: 8250_bcm2835aux: return PTR_ERR when fail to acquire clk

Add error handling process when fail to acquire clk by
`devm_clk_get_optional`.

Signed-off-by: Zeng Heng <zengheng4@...wei.com>
---
 drivers/tty/serial/8250/8250_bcm2835aux.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
index 15a2387a5b25..1c623e93232c 100644
--- a/drivers/tty/serial/8250/8250_bcm2835aux.c
+++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
@@ -119,6 +119,8 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev)
 
 	/* get the clock - this also enables the HW */
 	data->clk = devm_clk_get_optional(&pdev->dev, NULL);
+	if (IS_ERR(data->clk))
+		return PTR_ERR(data->clk);
 
 	/* get the interrupt */
 	ret = platform_get_irq(pdev, 0);
-- 
2.25.1