linux-kernel - Re: [PATCH v1 2/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: improve include notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 21:27:16 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>,
        Max Krummenacher <max.krummenacher@...adex.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-imx@....com" <linux-imx@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Andrejs Cainikovs <andrejs.cainikovs@...adex.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH v1 2/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: improve
 include notation

Hi Shawn

On Thu, 2022-09-22 at 18:29 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Improve include notation. Usually only dtsi files from the same location
> are included with an absolute path in quotes. Others should use a
> relative path enclosed in angle brackets.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> ---
> 
>  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 4 ++--
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-
> verdin.dtsi
> index b379c461aa13..a749d063c367 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -3,8 +3,8 @@
>   * Copyright 2022 Toradex
>   */
>  
> -#include "dt-bindings/phy/phy-imx8-pcie.h"
> -#include "dt-bindings/pwm/pwm.h"
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> +#include <dt-bindings/pwm/pwm.h>
>  #include "imx8mm.dtsi"
>  
>  / {
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-
> verdin.dtsi
> index 360be51a3527..ee4231d138fe 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -3,7 +3,8 @@
>   * Copyright 2022 Toradex
>   */
>  
> -#include "dt-bindings/pwm/pwm.h"
> +#include <dt-bindings/phy/phy-imx8-pcie.h>

Sorry, I just noticed that above line slipped in from patch 6. However, at least it should not hurt as that
header file does indeed exist since quite a while when PCIe support got merged for the Mini.

> +#include <dt-bindings/pwm/pwm.h>
>  #include "imx8mp.dtsi"
>  
>  / {

Cheers

Marcel