linux-kernel - [PATCH] coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 23:46:19 +0200
From:   Nam Cao <namcaov@...il.com>
To:     Alexander Viro <viro@...iv.linux.org.uk>
Cc:     namcaov@...il.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE

The function dump_emit_page() is only called in dump_user_range(), which
is wrapped in #ifdef CONFIG_ELF_CORE. This causes a build error when
CONFIG_ELF_CORE is disabled:

  CC      fs/coredump.o
fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
  834 | static int dump_emit_page(struct coredump_params *cprm, struct page *page)
      |            ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE to avoid build problem.

Signed-off-by: Nam Cao <namcaov@...il.com>
---
 fs/coredump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/coredump.c b/fs/coredump.c
index 7bad7785e8e6..8663042ebe9c 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
 	}
 }
 
+#ifdef CONFIG_ELF_CORE
 static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 {
 	struct bio_vec bvec = {
@@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 
 	return 1;
 }
+#endif
 
 int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
 {
-- 
2.25.1