linux-kernel - Re: [PATCH v2] staging: wlan-ng: remove commented debug printk messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2022 06:08:42 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Deepak R Varma <drv@...lo.com>, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk
 messages

On Mon, Oct 24, 2022 at 10:08:00AM +0700, Bagas Sanjaya wrote:
> On 10/23/22 21:13, Greg KH wrote:
> >>> @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >>>  			wlandev->rx.cfack_cfpoll++;
> >>>  			break;
> >>>  		default:
> >>> -			/* printk("unknown"); */
> >>>  			wlandev->rx.data_unknown++;
> >>>  			break;
> >>>  		}
> >>
> >> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?
> > 
> > No, they should just be removed as was done here.
> > 
> 
> What if in case of debugging without these printks?

I can not parse this line, sorry.