linux-kernel - Re: [PATCH] thermal/drivers/qcom/temp-alarm: fix inaccurate warning for gen2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2022 11:23:53 +0530
From:   Amit Kucheria <amitk@...nel.org>
To:     Luca Weiss <luca.weiss@...rphone.com>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Stephen Boyd <sboyd@...nel.org>,
        David Collins <collinsd@...eaurora.org>,
        Guru Das Srinagesh <gurus@...eaurora.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/drivers/qcom/temp-alarm: fix inaccurate warning
 for gen2

On Thu, Oct 20, 2022 at 8:23 PM Luca Weiss <luca.weiss@...rphone.com> wrote:
>
> On gen2 chips the stage2 threshold is not 140 degC but 125 degC.
>
> Make the warning message clearer by using this variable and also by
> including the temperature that was checked for.
>
> Fixes: aa92b3310c55 ("thermal/drivers/qcom-spmi-temp-alarm: Add support for GEN2 rev 1 PMIC peripherals")
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>

Reviewed-by: Amit Kucheria <amitk@...nel.org>

> ---
>  drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index be785ab37e53..ad84978109e6 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -252,7 +252,8 @@ static int qpnp_tm_update_critical_trip_temp(struct qpnp_tm_chip *chip,
>                         disable_s2_shutdown = true;
>                 else
>                         dev_warn(chip->dev,
> -                                "No ADC is configured and critical temperature is above the maximum stage 2 threshold of 140 C! Configuring stage 2 shutdown at 140 C.\n");
> +                                "No ADC is configured and critical temperature %d mC is above the maximum stage 2 threshold of %ld mC! Configuring stage 2 shutdown at %ld mC.\n",
> +                                temp, stage2_threshold_max, stage2_threshold_max);
>         }
>
>  skip:
> --
> 2.38.1
>