linux-kernel - [ammarfaizi2-block:crng/random/jd/canary-mask 9/10] arch/x86/kernel/smpboot.c:1050:2: error: implicit declaration of function 'cpu_init_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2022 09:02:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Jason A. Donenfeld" <zx2c4@...nel.org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:crng/random/jd/canary-mask 9/10]
 arch/x86/kernel/smpboot.c:1050:2: error: implicit declaration of function
 'cpu_init_stack_canary' is invalid in C99

tree:   https://github.com/ammarfaizi2/linux-block crng/random/jd/canary-mask
head:   a07711c2f9d0a5be66a965784a73e6c2c7a837d8
commit: fcc6279dcb571e541e585909b1946ef4d240990d [9/10] stackprotector: move CANARY_MASK and get_random_canary() into stackprotector.h
config: i386-randconfig-a013
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/fcc6279dcb571e541e585909b1946ef4d240990d
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block crng/random/jd/canary-mask
        git checkout fcc6279dcb571e541e585909b1946ef4d240990d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/x86/kernel/smpboot.c:1050:2: error: implicit declaration of function 'cpu_init_stack_canary' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           cpu_init_stack_canary(cpu, idle);
           ^
   arch/x86/kernel/smpboot.c:1050:2: note: did you mean 'boot_init_stack_canary'?
   include/linux/stackprotector.h:31:20: note: 'boot_init_stack_canary' declared here
   static inline void boot_init_stack_canary(void)
                      ^
   1 error generated.


vim +/cpu_init_stack_canary +1050 arch/x86/kernel/smpboot.c

e1c467e69040c3 Fenghua Yu      2012-11-14  1041  
66c7ceb47f628c Thomas Gleixner 2019-04-14  1042  int common_cpu_up(unsigned int cpu, struct task_struct *idle)
3f85483bd80ef1 Boris Ostrovsky 2015-04-01  1043  {
66c7ceb47f628c Thomas Gleixner 2019-04-14  1044  	int ret;
66c7ceb47f628c Thomas Gleixner 2019-04-14  1045  
3f85483bd80ef1 Boris Ostrovsky 2015-04-01  1046  	/* Just in case we booted with a single CPU. */
3f85483bd80ef1 Boris Ostrovsky 2015-04-01  1047  	alternatives_enable_smp();
3f85483bd80ef1 Boris Ostrovsky 2015-04-01  1048  
3f85483bd80ef1 Boris Ostrovsky 2015-04-01  1049  	per_cpu(current_task, cpu) = idle;
c9a1ff316bc9b1 Brian Gerst     2020-06-17 @1050  	cpu_init_stack_canary(cpu, idle);
3f85483bd80ef1 Boris Ostrovsky 2015-04-01  1051  
66c7ceb47f628c Thomas Gleixner 2019-04-14  1052  	/* Initialize the interrupt stack(s) */
66c7ceb47f628c Thomas Gleixner 2019-04-14  1053  	ret = irq_init_percpu_irqstack(cpu);
66c7ceb47f628c Thomas Gleixner 2019-04-14  1054  	if (ret)
66c7ceb47f628c Thomas Gleixner 2019-04-14  1055  		return ret;
66c7ceb47f628c Thomas Gleixner 2019-04-14  1056  

:::::: The code at line 1050 was first introduced by commit
:::::: c9a1ff316bc9b1d1806a4366d0aef6e18833ba52 x86/stackprotector: Pre-initialize canary for secondary CPUs

:::::: TO: Brian Gerst <brgerst@...il.com>
:::::: CC: Borislav Petkov <bp@...e.de>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (155663 bytes)