| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <fc923325-335d-e768-ea72-ba1712320d9d@linaro.org>
Date: Mon, 24 Oct 2022 08:29:57 -0400
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-kernel@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>,
Simtec Linux Team <linux@...tec.co.uk>,
Arnd Bergmann <arnd@...db.de>,
Alim Akhtar <alim.akhtar@...sung.com>,
Mark Brown <broonie@...nel.org>,
Juerg Haefliger <juerg.haefliger@...onical.com>,
Linus Walleij <linus.walleij@...aro.org>,
Tomasz Figa <tomasz.figa@...il.com>,
Heiko Stuebner <heiko@...ech.de>,
linux-samsung-soc@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 05/21] ARM: s3c: simplify platform code
On 21/10/2022 16:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Following down the now unused symbols and header files, some additional
> content can be dropped that is used by neither the s3c64xx DT support
> nor the crag6410 board.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> arch/arm/mach-s3c/Kconfig | 50 --
> arch/arm/mach-s3c/Kconfig.s3c64xx | 5 -
> arch/arm/mach-s3c/Makefile | 2 -
> arch/arm/mach-s3c/Makefile.s3c64xx | 1 -
> arch/arm/mach-s3c/adc-core.h | 24 -
> arch/arm/mach-s3c/ata-core-s3c64xx.h | 24 -
> arch/arm/mach-s3c/backlight-s3c64xx.h | 22 -
> arch/arm/mach-s3c/cpu.h | 47 --
> arch/arm/mach-s3c/dev-audio-s3c64xx.c | 127 ----
> arch/arm/mach-s3c/devs.c | 725 -------------------
> arch/arm/mach-s3c/devs.h | 37 -
> arch/arm/mach-s3c/dma-s3c64xx.h | 57 --
> arch/arm/mach-s3c/dma.h | 2 -
> arch/arm/mach-s3c/gpio-cfg-helpers.h | 124 ----
> arch/arm/mach-s3c/gpio-cfg.h | 19 -
> arch/arm/mach-s3c/gpio-core.h | 3 -
> arch/arm/mach-s3c/gpio-samsung.c | 443 +----------
> arch/arm/mach-s3c/iic-core.h | 7 -
> arch/arm/mach-s3c/init.c | 26 +-
> arch/arm/mach-s3c/map-s3c.h | 37 -
> arch/arm/mach-s3c/onenand-core-s3c64xx.h | 32 -
> arch/arm/mach-s3c/otom.h | 25 -
> arch/arm/mach-s3c/pm-core-s3c64xx.h | 17 -
> arch/arm/mach-s3c/pm-s3c64xx.c | 83 ---
> arch/arm/mach-s3c/pm.c | 7 +-
> arch/arm/mach-s3c/pm.h | 12 -
> arch/arm/mach-s3c/regs-srom-s3c64xx.h | 55 --
> arch/arm/mach-s3c/s3c6400.c | 6 -
> arch/arm/mach-s3c/s3c6410.c | 9 -
> arch/arm/mach-s3c/sdhci.h | 25 -
> arch/arm/mach-s3c/setup-ide-s3c64xx.c | 40 -
> arch/arm/mach-s3c/sleep-s3c64xx.S | 27 -
> include/linux/platform_data/media/s5p_hdmi.h | 32 -
> 33 files changed, 6 insertions(+), 2146 deletions(-)
> delete mode 100644 arch/arm/mach-s3c/adc-core.h
> delete mode 100644 arch/arm/mach-s3c/ata-core-s3c64xx.h
> delete mode 100644 arch/arm/mach-s3c/backlight-s3c64xx.h
> delete mode 100644 arch/arm/mach-s3c/dma-s3c64xx.h
> delete mode 100644 arch/arm/mach-s3c/dma.h
> delete mode 100644 arch/arm/mach-s3c/onenand-core-s3c64xx.h
> delete mode 100644 arch/arm/mach-s3c/otom.h
> delete mode 100644 arch/arm/mach-s3c/regs-srom-s3c64xx.h
> delete mode 100644 arch/arm/mach-s3c/setup-ide-s3c64xx.c
> delete mode 100644 include/linux/platform_data/media/s5p_hdmi.h
>
> diff --git a/arch/arm/mach-s3c/Kconfig b/arch/arm/mach-s3c/Kconfig
> index 0dde4010aa64..b3656109f1f7 100644
> --- a/arch/arm/mach-s3c/Kconfig
> +++ b/arch/arm/mach-s3c/Kconfig
> @@ -90,36 +90,6 @@ config S3C_DEV_I2C1
> help
> Compile in platform device definitions for I2C channel 1
>
> -config S3C_DEV_I2C2
> - bool
> - help
> - Compile in platform device definitions for I2C channel 2
> -
> -config S3C_DEV_I2C3
> - bool
> - help
> - Compile in platform device definition for I2C controller 3
> -
> -config S3C_DEV_I2C4
> - bool
> - help
> - Compile in platform device definition for I2C controller 4
> -
> -config S3C_DEV_I2C5
> - bool
> - help
> - Compile in platform device definition for I2C controller 5
> -
> -config S3C_DEV_I2C6
> - bool
> - help
> - Compile in platform device definition for I2C controller 6
> -
> -config S3C_DEV_I2C7
> - bool
> - help
> - Compile in platform device definition for I2C controller 7
> -
> config S3C_DEV_FB
> bool
> help
> @@ -135,26 +105,6 @@ config S3C_DEV_USB_HSOTG
> help
> Compile in platform device definition for USB high-speed OtG
>
> -config S3C_DEV_WDT
> - bool
> - help
> - Compile in platform device definition for Watchdog Timer
> -
> -config S3C_DEV_NAND
> - bool
> - help
> - Compile in platform device definition for NAND controller
> -
> -config S3C_DEV_ONENAND
> - bool
> - help
> - Compile in platform device definition for OneNAND controller
> -
> -config S3C_DEV_RTC
> - bool
> - help
> - Compile in platform device definition for RTC
> -
> config S3C64XX_DEV_SPI0
> bool
> help
> diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
> index c403d7642f0a..c52c7ce1d8fa 100644
> --- a/arch/arm/mach-s3c/Kconfig.s3c64xx
> +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
> @@ -15,12 +15,9 @@ menuconfig ARCH_S3C64XX
> select HAVE_TCM
> select PLAT_SAMSUNG
> select PM_GENERIC_DOMAINS if PM
> - select S3C_DEV_NAND if ATAGS
> select S3C_GPIO_TRACK if ATAGS
> - select S3C2410_WATCHDOG
This does not seem right. S3C2410_WATCHDOG is a driver used by all
(including Exynos) platforms.
> select SAMSUNG_ATAGS if ATAGS
> select SAMSUNG_WAKEMASK if PM
> - select WATCHDOG
> help
> Samsung S3C64XX series based systems
>
> @@ -121,10 +118,8 @@ config MACH_WLF_CRAGG_6410
> select S3C_DEV_HSMMC1
> select S3C_DEV_HSMMC2
> select S3C_DEV_I2C1
> - select S3C_DEV_RTC
This as well.
> select S3C_DEV_USB_HOST
> select S3C_DEV_USB_HSOTG
> - select S3C_DEV_WDT
> select SAMSUNG_DEV_KEYPAD
> select SAMSUNG_DEV_PWM
> help
Best regards,
Krzysztof
Powered by blists - more mailing lists