linux-kernel - Re: [PATCH v4] scsi:iscsi: Fix multiple iscsi session unbind event sent to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4e4c09b-9426-eede-a83c-8c55f6dc7d2d@huawei.com>
Date:   Mon, 24 Oct 2022 20:50:17 +0800
From:   Wenchao Hao <haowenchao@...wei.com>
To:     Mike Christie <michael.christie@...cle.com>,
        Lee Duncan <lduncan@...e.com>, Chris Leech <cleech@...hat.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Steffen Maier <maier@...ux.ibm.com>, <liuzhiqiang26@...wei.com>,
        <linfeilong@...wei.com>
Subject: Re: [PATCH v4] scsi:iscsi: Fix multiple iscsi session unbind event
 sent to userspace


On 2022/10/23 11:21, Mike Christie wrote:
>> I have some wonder about the target_id like be2iscsi which allocated from 
>> iscsi_sess_ida. Should not we get the target_id from iSCSI target?
>> If they allocate target_id with an random value, how to handle the
>> iscsi_user_scan_session which would check the session's target_id.
>>
> For iscsi, that target id is only a number that's used on the initiator side
> to track the target. The target has no idea what it is and it's never
> sent/used/passed to the target.
> 
> For example, the qla4xxx driver uses it to lookup persistent target info it
> has stored on it's flash. The other use is that we need a unique name for
> the target in sysfs and that target id is used as part of that name.
> .

Thanks for your answer, I would update this patch and open-iscsi's PR.