linux-kernel - Re: [PATCH 17/21] input: remove s3c24xx touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a074e9c5-7a1e-4b76-b75e-9f46d621ec0e@app.fastmail.com>
Date:   Mon, 24 Oct 2022 15:02:07 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Arnd Bergmann" <arnd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:     linux-kernel@...r.kernel.org, "Ben Dooks" <ben-linux@...ff.org>,
        "Simtec Linux Team" <linux@...tec.co.uk>,
        "Alim Akhtar" <alim.akhtar@...sung.com>,
        linux-input@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 17/21] input: remove s3c24xx touchscreen driver

On Mon, Oct 24, 2022, at 14:50, Krzysztof Kozlowski wrote:
> On 21/10/2022 16:27, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The s3c24xx SoC support and its adc driver was removed, so this driver
>> has no remaining users.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/input/touchscreen/Kconfig      |  12 -
>>  drivers/input/touchscreen/Makefile     |   1 -
>>  drivers/input/touchscreen/s3c2410_ts.c | 464 -------------------------
>>  3 files changed, 477 deletions(-)
>
> This also could be usable on S3C64xx, but it seems no one added any DT
> nodes, so:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thanks. To clarify, the key bit here is the 'depends on S3C_ADC',
and that driver in turn 'depends on !ARCH_MULTIPLATFORM' since
2014. So even for the boardfile variant of s3c64xx, it was
already impossible to use for a long time without anyone complaining
or trying to fix it.

     Arnd