linux-kernel - Re: [PATCH v2 0/9] mm/ksm: break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c14a306e-2814-2c9a-21f6-35d477b0fe3d@redhat.com>
Date:   Mon, 24 Oct 2022 15:32:52 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Shuah Khan <shuah@...nel.org>, Hugh Dickins <hughd@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Peter Xu <peterx@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Jason Gunthorpe <jgg@...dia.com>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes

On 21.10.22 21:57, Andrew Morton wrote:
> On Fri, 21 Oct 2022 12:11:32 +0200 David Hildenbrand <david@...hat.com> wrote:
> 
>> This series cleans up and fixes break_ksm().
> 
> Quite a lot of fixups were needed merging this.  I guess you couldn't
> develop against mm-unstable because the v1 series was already in there.

Nowadays, I tend to send against mm-stable (I remember that was the 
suggestion). Usually it works because there are no conflicts -- this 
time there are probably quite some kvm unit test conflicts.

Feel free to ask me next time to rebase on XYZ so I can make you life 
easier ;)

> 
> For this reason I'll henceforth be more inclined to drop serieses when
> I know a full resend is coming out.

Yes, good idea. While the fixup-patch process works for small 
adjustments, it's not a good fit for bigger changes, especially once 
involving new patches.

> 
> So please do let me know when a full resend is coming out. 

Will do; I kind-of did that [1] but I should have been more clear 
("Please drop the current series, I'll send a new version.").

> Or, of
> course, send little fixes against the current version.

I prefer a full resend when there are bigger changes that involve 
modifications to multiple patches ... which also makes life easier for 
reviewers.

[1] 
https://lore.kernel.org/all/87104912-6615-4917-eae1-6ae0a80677e1@redhat.com/T/#u

-- 
Thanks,

David / dhildenb