linux-kernel - Re: [PATCH v5 2/3] Input: add driver for Himax hx83112b touchscreen devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CNU7K2WVE8IR.3400IWODUPYYK@ancom>
Date:   Mon, 24 Oct 2022 16:03:30 +0200
From:   "Job Noorman" <job@...rman.info>
To:     "Jeff LaBundy" <jeff@...undy.com>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Henrik Rydberg" <rydberg@...math.org>,
        "Luca Weiss" <luca@...tu.xyz>, <linux-kernel@...r.kernel.org>,
        <linux-input@...r.kernel.org>
Subject: Re: [PATCH v5 2/3] Input: add driver for Himax hx83112b touchscreen
 devices

Hi Jeff,

On Sun Oct 23, 2022 at 10:07 PM CEST, Jeff LaBundy wrote:
> Hi Job,
>
> Looks great; just a few tiny nits that I missed last time. Sorry
> about that!

No problem!

> > +	ts->regmap = devm_regmap_init_i2c(client, &himax_regmap_config);
> > +	error = PTR_ERR_OR_ZERO(ts->regmap);
> > +	if (error) {
> > +		dev_err(&client->dev,
>
> We already have a locally declared dev pointer which at this point is
> equal to &client->dev as well as &ts->client->dev, so we can just use
> that here instead.

Nice catch! Fixed this one and all others in v6.

> With those remaining points resolved:
>
> Reviewed-by: Jeff LaBundy <jeff@...undy.com>

Thanks! Added in v6.

Kind regards,
Job