linux-kernel - Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2022 09:20:48 -0500
From:   Corey Minyard <minyard@....org>
To:     Quan Nguyen <quan@...amperecomputing.com>
Cc:     Open Source Submission <patches@...erecomputing.com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
        Phong Vo <phong@...amperecomputing.com>,
        thang@...amperecomputing.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN

On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote:
> This fixes the following sparse warning:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    left side has type restricted __poll_t
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    right side has type int

Thanks, you beat me to tracing this down.  It's in my for-next queue.

-corey

> 
> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/
> Signed-off-by: Quan Nguyen <quan@...amperecomputing.com>
> ---
>  drivers/char/ipmi/ssif_bmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index a7bb4b99000e..2d8069386398 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
>  	spin_lock_irq(&ssif_bmc->lock);
>  	/* The request is available, userspace application can get the request */
>  	if (ssif_bmc->request_available)
> -		mask |= POLLIN;
> +		mask |= EPOLLIN;
>  
>  	spin_unlock_irq(&ssif_bmc->lock);
>  
> -- 
> 2.35.1
>