[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221024072421.GB653394@raju-project-pc>
Date: Mon, 24 Oct 2022 12:54:21 +0530
From: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
<linux-kernel@...r.kernel.org>, <lxu@...linear.com>,
<hkallweit1@...il.com>, <pabeni@...hat.com>, <edumazet@...gle.com>,
<linux@...linux.org.uk>, <UNGLinuxDriver@...rochip.com>,
<Ian.Saturley@...rochip.com>
Subject: Re: [PATCH net-next] net: phy: mxl-gpy: Add PHY Auto/MDI/MDI-X set
driver for GPY211 chips
Hi Andrew,
Thank you for review comments.
The 10/21/2022 16:01, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> > +static void gpy_update_mdix(struct phy_device *phydev)
> > +{
> > + int ret;
> > +
> > + ret = phy_read(phydev, PHY_CTL1);
> > + if (ret < 0) {
> > + phydev_err(phydev, "Error: MDIO register access failed: %d\n",
> > + ret);
> > + return;
> > + }
>
> > @@ -413,6 +490,8 @@ static void gpy_update_interface(struct phy_device *phydev)
> >
> > if (phydev->speed == SPEED_2500 || phydev->speed == SPEED_1000)
> > genphy_read_master_slave(phydev);
> > +
> > + gpy_update_mdix(phydev);
>
> Do you know why gpy_update_interface() is a void function? It is
> called from gpy_read_status() which does return error codes. And it
> seems like gpy_read_status() would benefit from returning -EINVAL, etc.
Do you want me to change gpy_update_interface() return type ?
Can I do those changes as part of this commit or need to fix on "net"
branch ?
>
> Andrew
--
--------
Thanks,
Raju
Powered by blists - more mailing lists