| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ed665ca3-fa87-fee6-7284-9aed257264e4@intel.com>
Date: Mon, 24 Oct 2022 15:26:00 +0800
From: "Chen, Rong A" <rong.a.chen@...el.com>
To: Steven Rostedt <rostedt@...dmis.org>,
kernel test robot <lkp@...el.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [kbuild-all] Re: include/trace/trace_events.h:261:16: error:
function 'trace_event_get_offsets_iwlwifi_dbg' might be a candidate for
'gnu_printf' format attribute
On 10/21/2022 10:10 PM, Steven Rostedt wrote:
> On Fri, 21 Oct 2022 22:07:17 +0800
> kernel test robot <lkp@...el.com> wrote:
>
>> Hi Steven,
>>
>> FYI, the error/warning still remains.
>
> WONT FIX
>
> I thought we already discussed getting rid of this warning?
Hi Steve,
Sorry for the noise, the bot doesn't ignore this warning with prefix
'error:', we will fix it.
Best Regards,
Rong Chen
>
> -- Steve
>
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: e35184f321518acadb681928a016da21a9a20c13
>> commit: c7c37bb87590886e08d24dec53089f74b89f5fbb tracing/iwlwifi: Use the new __vstring() helper
>> date: 3 months ago
>> config: x86_64-sof-customedconfig-edison-defconfig
>> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
>> reproduce (this is a W=1 build):
>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c7c37bb87590886e08d24dec53089f74b89f5fbb
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git fetch --no-tags linus master
>> git checkout c7c37bb87590886e08d24dec53089f74b89f5fbb
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/wireless/intel/iwlwifi/
>>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@...el.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> In file included from include/trace/define_trace.h:102,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace-msg.h:71,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace.h:91,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:
>> drivers/net/wireless/intel/iwlwifi/./iwl-devtrace-msg.h: In function 'trace_event_get_offsets_iwlwifi_dbg':
>>>> include/trace/trace_events.h:261:16: error: function 'trace_event_get_offsets_iwlwifi_dbg' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
>> 261 | struct trace_event_raw_##call __maybe_unused *entry; \
>> | ^~~~~~~~~~~~~~~~
>> include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
>> 40 | DECLARE_EVENT_CLASS(name, \
>> | ^~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intel/iwlwifi/./iwl-devtrace-msg.h:49:1: note: in expansion of macro 'TRACE_EVENT'
>> 49 | TRACE_EVENT(iwlwifi_dbg,
>> | ^~~~~~~~~~~
>> In file included from include/trace/define_trace.h:102,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace-msg.h:71,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace.h:91,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:
>> drivers/net/wireless/intel/iwlwifi/./iwl-devtrace-msg.h: In function 'trace_event_raw_event_iwlwifi_dbg':
>> include/trace/trace_events.h:386:16: error: function 'trace_event_raw_event_iwlwifi_dbg' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
>> 386 | struct trace_event_raw_##call *entry; \
>> | ^~~~~~~~~~~~~~~~
>> include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
>> 40 | DECLARE_EVENT_CLASS(name, \
>> | ^~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intel/iwlwifi/./iwl-devtrace-msg.h:49:1: note: in expansion of macro 'TRACE_EVENT'
>> 49 | TRACE_EVENT(iwlwifi_dbg,
>> | ^~~~~~~~~~~
>> In file included from include/trace/define_trace.h:103,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace-msg.h:71,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace.h:91,
>> from drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:
>> drivers/net/wireless/intel/iwlwifi/./iwl-devtrace-msg.h: In function 'perf_trace_iwlwifi_dbg':
>> include/trace/perf.h:64:16: error: function 'perf_trace_iwlwifi_dbg' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
>> 64 | struct hlist_head *head; \
>> | ^~~~~~~~~~
>> include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
>> 40 | DECLARE_EVENT_CLASS(name, \
>> | ^~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intel/iwlwifi/./iwl-devtrace-msg.h:49:1: note: in expansion of macro 'TRACE_EVENT'
>> 49 | TRACE_EVENT(iwlwifi_dbg,
>> | ^~~~~~~~~~~
>> cc1: all warnings being treated as errors
>>
>>
>> vim +261 include/trace/trace_events.h
>>
>> 55de2c0b5610cb include/trace/trace_events.h Masami Hiramatsu 2021-11-22 253
>> 091ad3658e3c76 include/trace/ftrace.h Ingo Molnar 2009-11-26 254 #undef DECLARE_EVENT_CLASS
>> 091ad3658e3c76 include/trace/ftrace.h Ingo Molnar 2009-11-26 255 #define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \
>> d0ee8f4a1f5f3d include/trace/trace_events.h Steven Rostedt (Red Hat 2015-05-13 256) static inline notrace int trace_event_get_offsets_##call( \
>> 62323a148fbeb0 include/trace/trace_events.h Steven Rostedt (Red Hat 2015-05-13 257) struct trace_event_data_offsets_##call *__data_offsets, proto) \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 258 { \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 259 int __data_size = 0; \
>> 114e7b52dee69c include/trace/ftrace.h Filipe Brandenburger 2014-02-28 260 int __maybe_unused __item_length; \
>> a7237765730a10 include/trace/trace_events.h Steven Rostedt (Red Hat 2015-05-13 @261) struct trace_event_raw_##call __maybe_unused *entry; \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 262 \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 263 tstruct; \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 264 \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 265 return __data_size; \
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 266 }
>> 7fcb7c472f455d include/trace/ftrace.h Li Zefan 2009-06-01 267
>>
>> :::::: The code at line 261 was first introduced by commit
>> :::::: a7237765730a10d429736f47ac4b89779ec6c534 tracing: Rename ftrace_raw_##call event structures to trace_event_raw_##call
>>
>> :::::: TO: Steven Rostedt (Red Hat) <rostedt@...dmis.org>
>> :::::: CC: Steven Rostedt <rostedt@...dmis.org>
>>
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@...ts.01.org
> To unsubscribe send an email to kbuild-all-leave@...ts.01.org
>
Powered by blists - more mailing lists