linux-kernel - Re: [rft, PATCH v1 4/4] kernel.h: Split out ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1a3vpiy8RBGfbsI@smile.fi.intel.com>
Date:   Mon, 24 Oct 2022 19:05:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     mingo@...nel.org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [rft, PATCH v1 4/4] kernel.h: Split out ARRAY_SZIE()

On Mon, Oct 24, 2022 at 06:44:50PM +0300, Alexey Dobriyan wrote:
> > include/linux/array_size.h | 13 +++++++++++++
> 
> All of this is pessimisation unless you're removing
> 
> 	+#include <linux/array_size.h>
> 
> from kernel.h which you aren't doing.
> 
> container_of.h is just as silly.
> 
> kernel.h might need _some_ cleanup (like panic and tainted stuff) which
> is rarely used but ARRAY_SIZE()?

Are you suggesting to slow down compilation with inclusion of tons of unneeded
stuff in the zillions of drivers?

Or you are talking that we need to abandon most of the headers and combine
everything into kernel.h? I think this is what is silly.


-- 
With Best Regards,
Andy Shevchenko