linux-kernel - Re: [PATCH v4 2/3] iio: accel: Support Kionix/ROHM KX022A accelerometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e6d331b-0cc3-de9b-9fa2-96981f594c83@gmail.com>
Date:   Mon, 24 Oct 2022 17:16:12 +0300
From:   Matti Vaittinen <mazziesaccount@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     DDRokosov@...rdevices.ru, andriy.shevchenko@...ux.intel.com,
        demonsingur@...il.com, devicetree@...r.kernel.org,
        jagathjog1996@...il.com, jic23@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, lars@...afoo.de,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        matti.vaittinen@...rohmeurope.com, nikita.yoush@...entembedded.com,
        robh+dt@...nel.org
Subject: Re: [PATCH v4 2/3] iio: accel: Support Kionix/ROHM KX022A
 accelerometer

Thanks for the review Christophe,

On 10/24/22 16:34, Christophe JAILLET wrote:
> Le 21/10/2022 à 13:22, Matti Vaittinen a écrit :
>> KX022A is a 3-axis accelerometer from ROHM/Kionix. The sensor features
>> include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ,
>> tap/motion detection, wake-up & back-to-sleep events, four acceleration
>> ranges (2, 4, 8 and 16g), and probably some other cool features.
>>
>> Add support for the basic accelerometer features such as getting the
>> acceleration data via IIO. (raw reads, triggered buffer [data-ready] or
>> using the WMI IRQ).
>>
>> Important things to be added include the double-tap, motion
>> detection and wake-up as well as the runtime power management.
>>
>> Signed-off-by: Matti Vaittinen 
>> <mazziesaccount-Re5JQEeQqe8AvxtiuMwx3w@...lic.gmane.org>
>>
>> ---
> 
> Hi, should there be a v5:

I did already send out the v5 shortly before your review. If I need to 
send v6 I'll apply your suggestions.


Yours
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~