linux-kernel - Re: [PATCH v2] mm: memory-failure: make action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221024073552.GA4043713@hori.linux.bs1.fc.nec.co.jp>
Date:   Mon, 24 Oct 2022 07:35:52 +0000
From:   HORIGUCHI NAOYA(堀口　直也) 
        <naoya.horiguchi@....com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Miaohe Lin <linmiaohe@...wei.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mm: memory-failure: make action_result() return int

On Mon, Oct 24, 2022 at 11:51:38AM +0800, Kefeng Wang wrote:
> Check mf_result in action_result(), only return 0 when
> MF_RECOVERED/MF_DELAYED, or return -EBUSY, which will
> simplify code a bit.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
> v2: 
> - MF_DELAYED is considered as success, suggested by HORIGUCHI
> - adjust order between unlock_page(head) and action_result()
>   after !hwpoison_user_mappings() to clean code more in
>   try_memory_failure_hugetlb()
> 

Thank you for the update. The patch looks good to me.

Acked-by: Naoya Horiguchi <naoya.horiguchi@....com>