linux-kernel - Re: [PATCH for-next v3 1/2] RDMA/rxe: Remove unnecessary mr testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2022 14:16:14 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Li Zhijian <lizhijian@...itsu.com>
Cc:     zyjzyj2000@...il.com, leon@...nel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bob Pearson <rpearsonhpe@...il.com>
Subject: Re: [PATCH for-next v3 1/2] RDMA/rxe: Remove unnecessary mr testing

On Mon, Oct 24, 2022 at 03:31:54AM +0000, Li Zhijian wrote:
> Before the testing, we already passed it to rxe_mr_copy() where mr could
> be dereferenced. so this checking is not needed.
> 
> The only way that mr is NULL is when it reaches below line 780 with
>  'qp->resp.mr = NULL', which is not possible in Bob's explanation[1].
> 
>  778         if (res->state == rdatm_res_state_new) {
>  779                 if (!res->replay) {
>  780                         mr = qp->resp.mr;
>  781                         qp->resp.mr = NULL;
>  782                 } else {
> 
> [1] https://lore.kernel.org/lkml/30ff25c4-ce66-eac4-eaa2-64c0db203a19@gmail.com/
> 
> CC: Bob Pearson <rpearsonhpe@...il.com>
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> Reviewed-by: Bob Pearson <rpearsonhpe@...il.com>
> ---
> V3: remove WARN_ON # Yanjun and Bob
> ---
>  drivers/infiniband/sw/rxe/rxe_resp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next

Thanks,
Jason