[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <709b3a2e-4dfa-52e1-a75e-f72d73bd97a8@gmail.com>
Date: Mon, 24 Oct 2022 11:02:40 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Brian Norris <briannorris@...omium.org>,
Ulf Hansson <ulf.hansson@...aro.org>
Cc: Shawn Lin <shawn.lin@...k-chips.com>, linux-mmc@...r.kernel.org,
Al Cooper <alcooperx@...il.com>,
Bjorn Andersson <andersson@...nel.org>,
Sowjanya Komatineni <skomatineni@...dia.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Florian Fainelli <f.fainelli@...il.com>,
NXP Linux Team <linux-imx@....com>,
Thierry Reding <thierry.reding@...il.com>,
Fabio Estevam <festevam@...il.com>,
Michal Simek <michal.simek@...inx.com>,
linux-kernel@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
linux-arm-msm@...r.kernel.org, Haibo Chen <haibo.chen@....com>,
Andy Gross <agross@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
Faiz Abbas <faiz_abbas@...com>,
Jonathan Hunter <jonathanh@...dia.com>, stable@...r.kernel.org
Subject: Re: [PATCH v3 1/7] mmc: cqhci: Provide helper for resetting both
SDHCI and CQHCI
On 10/24/22 10:54, Brian Norris wrote:
> Several SDHCI drivers need to deactivate command queueing in their reset
> hook (see sdhci_cqhci_reset() / sdhci-pci-core.c, for example), and
> several more are coming.
>
> Those reset implementations have some small subtleties (e.g., ordering
> of initialization of SDHCI vs. CQHCI might leave us resetting with a
> NULL ->cqe_private), and are often identical across different host
> drivers.
>
> We also don't want to force a dependency between SDHCI and CQHCI, or
> vice versa; non-SDHCI drivers use CQHCI, and SDHCI drivers might support
> command queueing through some other means.
>
> So, implement a small helper, to avoid repeating the same mistakes in
> different drivers. Simply stick it in a header, because it's so small it
> doesn't deserve its own module right now, and inlining to each driver is
> pretty reasonable.
>
> This is marked for -stable, as it is an important prerequisite patch for
> several SDHCI controller bugfixes that follow.
>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists