linux-kernel - Re: [PATCH 2/2] unicode: mkutf8data: Add malloc allocation check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1ZF040OJaJ31doE@debian.me>
Date:   Mon, 24 Oct 2022 14:59:15 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Li kunyu <kunyu@...china.com>
Cc:     krisman@...labora.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] unicode: mkutf8data: Add malloc allocation check

On Mon, Oct 24, 2022 at 12:51:50PM +0800, Li kunyu wrote:
> Increase the judgment of malloc allocation, and return NULL if the
> condition is met.
> 
> Signed-off-by: Li kunyu <kunyu@...china.com>
> ---
>  fs/unicode/mkutf8data.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/unicode/mkutf8data.c b/fs/unicode/mkutf8data.c
> index e06404a6b106..a929ddf1438c 100644
> --- a/fs/unicode/mkutf8data.c
> +++ b/fs/unicode/mkutf8data.c
> @@ -495,6 +495,9 @@ static struct node *alloc_node(struct node *parent)
>  	int bitnum;
>  
>  	node = malloc(sizeof(*node));
> +	if (!node)
> +		return NULL;
> +
>  	node->left = node->right = NULL;
>  	node->parent = parent;
>  	node->leftnode = NODE;

What?

This is not "malloc judgement", but rather return NULL if node fails to
allocate.

Please, please reword the patch description.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)