[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ec8edb92-a21b-6291-4275-d7cba97d7ad7@gmx.de>
Date: Mon, 24 Oct 2022 20:29:26 +0200
From: Helge Deller <deller@....de>
To: "Jason A. Donenfeld" <Jason@...c4.com>,
linux-kernel@...r.kernel.org
Cc: Thomas Winischhofer <thomas@...ischhofer.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] video: fbdev: sis: use explicitly signed char
On 10/24/22 18:29, Jason A. Donenfeld wrote:
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. This fixes warnings like:
>
> drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned
>
> Cc: Thomas Winischhofer <thomas@...ischhofer.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Helge Deller <deller@....de>
> Cc: linux-usb@...r.kernel.org
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
Applied to linux-fbdev git tree.
Thanks,
Helge
> ---
> drivers/usb/misc/sisusbvga/sisusb_struct.h | 2 +-
> drivers/video/fbdev/sis/vstruct.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/sisusbvga/sisusb_struct.h b/drivers/usb/misc/sisusbvga/sisusb_struct.h
> index 3df64d2a9d43..a86032a26d36 100644
> --- a/drivers/usb/misc/sisusbvga/sisusb_struct.h
> +++ b/drivers/usb/misc/sisusbvga/sisusb_struct.h
> @@ -91,7 +91,7 @@ struct SiS_Ext {
> unsigned char VB_ExtTVYFilterIndex;
> unsigned char VB_ExtTVYFilterIndexROM661;
> unsigned char REFindex;
> - char ROMMODEIDX661;
> + signed char ROMMODEIDX661;
> };
>
> struct SiS_Ext2 {
> diff --git a/drivers/video/fbdev/sis/vstruct.h b/drivers/video/fbdev/sis/vstruct.h
> index ea94d214dcff..d7a14e63ba5a 100644
> --- a/drivers/video/fbdev/sis/vstruct.h
> +++ b/drivers/video/fbdev/sis/vstruct.h
> @@ -148,7 +148,7 @@ struct SiS_Ext {
> unsigned char VB_ExtTVYFilterIndex;
> unsigned char VB_ExtTVYFilterIndexROM661;
> unsigned char REFindex;
> - char ROMMODEIDX661;
> + signed char ROMMODEIDX661;
> };
>
> struct SiS_Ext2 {
Powered by blists - more mailing lists