linux-kernel - Re: [PATCH 00/17] staging: r8188eu: clean up mlme handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4a70a29-4c27-c091-4332-dc476e258b74@gmail.com>
Date:   Mon, 24 Oct 2022 19:43:07 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/17] staging: r8188eu: clean up mlme handlers

On 10/24/22 10:14, Martin Kaiser wrote:
> This series cleans up the mlme handlers that process incoming management
> frames.
> 
> We can reorder the handler functions and remove forward declarations. We
> can also remove unused return values and simplify the error handling.
> 
> This series should be applied after the "some more small cleanups" series.
> 
> As usual, this series was tested with EdimaxV2 on an arm32 system.
> 
> Martin Kaiser (17):
>    staging: r8188eu: restructure mlme subfunction handling
>    staging: r8188eu: make OnAssocReq static
>    staging: r8188eu: make OnAssocRsp static
>    staging: r8188eu: make OnProbeReq static
>    staging: r8188eu: make OnProbeRsp static
>    staging: r8188eu: make OnBeacon static
>    staging: r8188eu: make OnDisassoc static
>    staging: r8188eu: make OnAuthClient static
>    staging: r8188eu: make OnDeAuth static
>    staging: r8188eu: make OnAction static
>    staging: r8188eu: make OnAuth static
>    staging: r8188eu: change mlme handlers to void
>    staging: r8188eu: remove unnecessary label
>    staging: r8188eu: remove unnecessary else branch
>    staging: r8188eu: remove unnecessary return
>    staging: r8188eu: remove an else branch
>    staging: r8188eu: go2asoc is not needed
> 
>   drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 226 ++++++++----------
>   .../staging/r8188eu/include/rtw_mlme_ext.h    |  23 +-
>   2 files changed, 100 insertions(+), 149 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150