linux-kernel - Re: [PATCH 0/3] PCI/portdrv: Squash into portdrv.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221024201521.GA587383@bhelgaas>
Date:   Mon, 24 Oct 2022 15:15:21 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     linux-pci@...r.kernel.org
Cc:     Stefan Roese <sr@...x.de>, Lukas Wunner <lukas@...ner.de>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Stuart Hayes <stuart.w.hayes@...il.com>,
        Keith Busch <kbusch@...nel.org>, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 0/3] PCI/portdrv: Squash into portdrv.c

On Wed, Oct 19, 2022 at 03:41:24PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The PCIe portdrv is split across portdrv_core.c and portdrv_pci.c, but
> neither is very big and it's a hassle to figure out which to look at.
> 
> Squash them into a single portdrv.c file.  Make functions static and
> non-exported when possible, and move some private things out of portdrv.h.
> 
> Please comment.
> 
> Bjorn Helgaas (3):
>   PCI/portdrv: Squash into portdrv.c
>   PCI/portdrv: Move private things to portdrv.c
>   PCI/portdrv: Unexport pcie_port_service_register(),
>     pcie_port_service_unregister()
> 
>  drivers/pci/pcie/Makefile                     |   2 +-
>  .../pci/pcie/{portdrv_core.c => portdrv.c}    | 263 +++++++++++++++++-
>  drivers/pci/pcie/portdrv.h                    |  19 --
>  drivers/pci/pcie/portdrv_pci.c                | 252 -----------------
>  4 files changed, 253 insertions(+), 283 deletions(-)
>  rename drivers/pci/pcie/{portdrv_core.c => portdrv.c} (69%)
>  delete mode 100644 drivers/pci/pcie/portdrv_pci.c

I applied these to pci/portdrv for v6.2 with Reviewed-Bys from
Christoph and Keith.  Thanks for taking a look!

Bjorn