linux-kernel - Re: [PATCH] ALSA: rme9652: use explicitly signed char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210250456.vKv5zoLb-lkp@intel.com>
Date:   Tue, 25 Oct 2022 04:54:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, "Jason A. Donenfeld" <Jason@...c4.com>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: rme9652: use explicitly signed char

Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on crng-random/master linus/master v6.1-rc2 next-20221024]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jason-A-Donenfeld/ALSA-rme9652-use-explicitly-signed-char/20221025-003249
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20221024162947.536060-1-Jason%40zx2c4.com
patch subject: [PATCH] ALSA: rme9652: use explicitly signed char
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3ec2c3ce47e18e3b4bfc225baf73d4420d6057c2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jason-A-Donenfeld/ALSA-rme9652-use-explicitly-signed-char/20221025-003249
        git checkout 3ec2c3ce47e18e3b4bfc225baf73d4420d6057c2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash sound/pci/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   sound/pci/rme9652/hdsp.c: In function 'snd_hdsp_midi_output_trigger':
>> sound/pci/rme9652/hdsp.c:1424:39: warning: increment of a boolean expression [-Wbool-operation]
    1424 |                         hmidi->istimer++;
         |                                       ^~
>> sound/pci/rme9652/hdsp.c:1427:39: warning: decrement of a boolean expression [-Wbool-operation]
    1427 |                 if (hmidi->istimer && --hmidi->istimer <= 0)
         |                                       ^~


vim +1424 sound/pci/rme9652/hdsp.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  1411  
55e957d8328ef1 Takashi Iwai   2005-11-17  1412  static void snd_hdsp_midi_output_trigger(struct snd_rawmidi_substream *substream, int up)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1413  {
55e957d8328ef1 Takashi Iwai   2005-11-17  1414  	struct hdsp_midi *hmidi;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1415  	unsigned long flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1416  
55e957d8328ef1 Takashi Iwai   2005-11-17  1417  	hmidi = (struct hdsp_midi *) substream->rmidi->private_data;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1418  	spin_lock_irqsave (&hmidi->lock, flags);
^1da177e4c3f41 Linus Torvalds 2005-04-16  1419  	if (up) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  1420  		if (!hmidi->istimer) {
7211ec6392c865 Kees Cook      2017-10-25  1421  			timer_setup(&hmidi->timer, snd_hdsp_midi_output_timer,
7211ec6392c865 Kees Cook      2017-10-25  1422  				    0);
c41c009ed5f0d2 Takashi Iwai   2015-01-19  1423  			mod_timer(&hmidi->timer, 1 + jiffies);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1424  			hmidi->istimer++;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1425  		}
^1da177e4c3f41 Linus Torvalds 2005-04-16  1426  	} else {
b0b9811956db48 Takashi Iwai   2005-10-20 @1427  		if (hmidi->istimer && --hmidi->istimer <= 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1428  			del_timer (&hmidi->timer);
^1da177e4c3f41 Linus Torvalds 2005-04-16  1429  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  1430  	spin_unlock_irqrestore (&hmidi->lock, flags);
^1da177e4c3f41 Linus Torvalds 2005-04-16  1431  	if (up)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1432  		snd_hdsp_midi_output_write(hmidi);
^1da177e4c3f41 Linus Torvalds 2005-04-16  1433  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  1434  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322067 bytes)