linux-kernel - Re: [PATCH v15 2/3] virt: Add TDX guest driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1aY/4SWwuDENigJ@kroah.com>
Date:   Mon, 24 Oct 2022 15:54:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wander Lairson Costa <wander@...hat.com>
Cc:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        Shuah Khan <shuah@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        "H . Peter Anvin" <hpa@...or.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Kai Huang <kai.huang@...el.com>,
        Isaku Yamahata <isaku.yamahata@...il.com>,
        marcelo.cerri@...onical.com, tim.gardner@...onical.com,
        khalid.elmously@...onical.com, philip.cox@...onical.com,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v15 2/3] virt: Add TDX guest driver

On Mon, Oct 24, 2022 at 09:57:53AM -0300, Wander Lairson Costa wrote:
> On Sun, Oct 23, 2022 at 1:13 PM Sathyanarayanan Kuppuswamy
> <sathyanarayanan.kuppuswamy@...ux.intel.com> wrote:
> >
> >
> >
> > On 10/20/22 9:39 PM, Greg Kroah-Hartman wrote:
> > >>> You are allowing userspace to spam the kernel logs, please do not do
> > >>> that.
> > >> Added it to help userspace understand the reason for the failure (only for
> > >> the cases like request param issues and TDCALL failure). Boris recommended
> > >> adding it in the previous review.
> > > Again, you just created a vector for userspace to spam the kernel log.
> > > No kernel driver should ever do that.
> > >
> >
> > Brois, any comments? Do you also agree?
> >
> 
> Maybe dev_err_once() does the job?

That does not make any sense when the userspace input can be different
each time.

This is just yet-another-ioctl, there's nothing special about it.
Return an error for invalid input and don't log anything.  Worst case,
make it a dev_dbg() call if you really really really want to see it.

thanks,

greg k-h