linux-kernel - Re: [PATCH] iommu: remove variable cnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221024203342.nbmqphmfbrqqtr4n@cantor>
Date:   Mon, 24 Oct 2022 13:33:42 -0700
From:   Jerry Snitselaar <jsnitsel@...hat.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Joerg Roedel <joro@...tes.org>,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: remove variable cnt

On Mon, Oct 24, 2022 at 02:43:01PM +0100, Colin Ian King wrote:
> Variable cnt is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/iommu/amd/iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index d3b39d0416fa..3847f3bdc568 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -767,7 +767,7 @@ EXPORT_SYMBOL(amd_iommu_register_ga_log_notifier);
>  
>  static void iommu_poll_ga_log(struct amd_iommu *iommu)
>  {
> -	u32 head, tail, cnt = 0;
> +	u32 head, tail;
>  
>  	if (iommu->ga_log == NULL)
>  		return;
> @@ -780,7 +780,6 @@ static void iommu_poll_ga_log(struct amd_iommu *iommu)
>  		u64 log_entry;
>  
>  		raw = (u64 *)(iommu->ga_log + head);
> -		cnt++;
>  
>  		/* Avoid memcpy function-call overhead */
>  		log_entry = *raw;
> -- 
> 2.37.3
> 

Reviewed-by: Jerry Snitselaar <jsnitsel@...hat.com>