lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51477b80-478f-d2cb-d98d-477431057fd4@gmail.com>
Date:   Mon, 24 Oct 2022 17:04:25 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Andrew Davis <afd@...com>, Shawn Guo <shawnguo@...nel.org>,
        Li Yang <leoyang.li@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     devicetree@...r.kernel.org, linux-kbuild@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/7] Rename DTB overlay source files

Hi Andrew,

On 10/24/22 12:34, Andrew Davis wrote:
> Hello all,
> 
> This is a series based on my patch here[0]. As suggested by Rob
> I've resurrected Frank's patch and appended it to mine as a series.
> 
> First patch here is my original patch, 3rd is Frank's patch but with
> the unittest changes pulled out into the 2nd patch. That was re-worked
> moving the source building macro into scripts/Makefile.lib.
> 
> Patches 4, 5, and 6 are an attempt at renaming all the existing DTB
> overlays. Split out by platform so they could be taken by platform
> maintainers or if easier ACK'd here and taken all together.
> 
> This should cover all the DTB overlays so we can remove the old .dts
> rule for overlays and make .dtso the only supported way, let me know
> if we want that this cycle and I can post that too.

Thanks for picking this up and moving it forward.  I've reviewed patches
1 - 3, and took a quick look at 4 - 7 (which also look fine at a glance).

-Frank

> 
> Thanks,
> Andrew
> 
> Changes from v1[1]:
>  - Added patch to rename pi433 overlay.
>  - Cleaned wording on patch 4-6.
>  - Collected some ACKs
> 
> [0] https://www.spinics.net/lists/kernel/msg4548509.html
> [1] https://www.spinics.net/lists/arm-kernel/msg1020165.html
> 
> Andrew Davis (6):
>   kbuild: Allow DTB overlays to built from .dtso named source files
>   kbuild: Allow DTB overlays to built into .dtso.S files
>   arm64: dts: freescale: Rename DTB overlay source files from .dts to
>     .dtso
>   arm64: dts: renesas: Rename DTB overlay source files from .dts to
>     .dtso
>   arm64: dts: xilinx: Rename DTB overlay source files from .dts to .dtso
>   staging: pi433: overlay: Rename overlay source file from .dts to .dtso
> 
> Frank Rowand (1):
>   of: overlay: rename overlay source files from .dts to .dtso
> 
>  ...qds-13bb.dts => fsl-ls1028a-qds-13bb.dtso} |  0
>  ...qds-65bb.dts => fsl-ls1028a-qds-65bb.dtso} |  0
>  ...qds-7777.dts => fsl-ls1028a-qds-7777.dtso} |  0
>  ...qds-85bb.dts => fsl-ls1028a-qds-85bb.dtso} |  0
>  ...qds-899b.dts => fsl-ls1028a-qds-899b.dtso} |  0
>  ...qds-9999.dts => fsl-ls1028a-qds-9999.dtso} |  0
>  ...ts => imx8mm-venice-gw72xx-0x-imx219.dtso} |  0
>  ...=> imx8mm-venice-gw72xx-0x-rs232-rts.dtso} |  0
>  ...dts => imx8mm-venice-gw72xx-0x-rs422.dtso} |  0
>  ...dts => imx8mm-venice-gw72xx-0x-rs485.dtso} |  0
>  ...ts => imx8mm-venice-gw73xx-0x-imx219.dtso} |  0
>  ...=> imx8mm-venice-gw73xx-0x-rs232-rts.dtso} |  0
>  ...dts => imx8mm-venice-gw73xx-0x-rs422.dtso} |  0
>  ...dts => imx8mm-venice-gw73xx-0x-rs485.dtso} |  0
>  ...2.dts => draak-ebisu-panel-aa104xd12.dtso} |  0
>  ...xd12.dts => salvator-panel-aa104xd12.dtso} |  0
>  ...v-g-revA.dts => zynqmp-sck-kv-g-revA.dtso} |  0
>  ...v-g-revB.dts => zynqmp-sck-kv-g-revB.dtso} |  0
>  drivers/of/unittest-data/Makefile             | 66 +++++++++----------
>  .../{overlay.dts => overlay.dtso}             |  0
>  .../{overlay_0.dts => overlay_0.dtso}         |  0
>  .../{overlay_1.dts => overlay_1.dtso}         |  0
>  .../{overlay_10.dts => overlay_10.dtso}       |  0
>  .../{overlay_11.dts => overlay_11.dtso}       |  0
>  .../{overlay_12.dts => overlay_12.dtso}       |  0
>  .../{overlay_13.dts => overlay_13.dtso}       |  0
>  .../{overlay_15.dts => overlay_15.dtso}       |  0
>  .../{overlay_16.dts => overlay_16.dtso}       |  0
>  .../{overlay_17.dts => overlay_17.dtso}       |  0
>  .../{overlay_18.dts => overlay_18.dtso}       |  0
>  .../{overlay_19.dts => overlay_19.dtso}       |  0
>  .../{overlay_2.dts => overlay_2.dtso}         |  0
>  .../{overlay_20.dts => overlay_20.dtso}       |  0
>  .../{overlay_3.dts => overlay_3.dtso}         |  0
>  .../{overlay_4.dts => overlay_4.dtso}         |  0
>  .../{overlay_5.dts => overlay_5.dtso}         |  0
>  .../{overlay_6.dts => overlay_6.dtso}         |  0
>  .../{overlay_7.dts => overlay_7.dtso}         |  0
>  .../{overlay_8.dts => overlay_8.dtso}         |  0
>  .../{overlay_9.dts => overlay_9.dtso}         |  0
>  ...node.dts => overlay_bad_add_dup_node.dtso} |  0
>  ...prop.dts => overlay_bad_add_dup_prop.dtso} |  0
>  ...d_phandle.dts => overlay_bad_phandle.dtso} |  0
>  ...bad_symbol.dts => overlay_bad_symbol.dtso} |  0
>  .../{overlay_base.dts => overlay_base.dtso}   |  0
>  ...erlay_gpio_01.dts => overlay_gpio_01.dtso} |  0
>  ...lay_gpio_02a.dts => overlay_gpio_02a.dtso} |  0
>  ...lay_gpio_02b.dts => overlay_gpio_02b.dtso} |  0
>  ...erlay_gpio_03.dts => overlay_gpio_03.dtso} |  0
>  ...lay_gpio_04a.dts => overlay_gpio_04a.dtso} |  0
>  ...lay_gpio_04b.dts => overlay_gpio_04b.dtso} |  0
>  .../{testcases.dts => testcases.dtso}         |  0
>  drivers/of/unittest.c                         | 48 +++++++-------
>  .../{pi433-overlay.dts => pi433-overlay.dtso} |  0
>  .../pi433/Documentation/devicetree/pi433.txt  |  6 +-
>  scripts/Makefile.lib                          | 23 ++++++-
>  56 files changed, 82 insertions(+), 61 deletions(-)
>  rename arch/arm64/boot/dts/freescale/{fsl-ls1028a-qds-13bb.dts => fsl-ls1028a-qds-13bb.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{fsl-ls1028a-qds-65bb.dts => fsl-ls1028a-qds-65bb.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{fsl-ls1028a-qds-7777.dts => fsl-ls1028a-qds-7777.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{fsl-ls1028a-qds-85bb.dts => fsl-ls1028a-qds-85bb.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{fsl-ls1028a-qds-899b.dts => fsl-ls1028a-qds-899b.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{fsl-ls1028a-qds-9999.dts => fsl-ls1028a-qds-9999.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw72xx-0x-imx219.dts => imx8mm-venice-gw72xx-0x-imx219.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw72xx-0x-rs232-rts.dts => imx8mm-venice-gw72xx-0x-rs232-rts.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw72xx-0x-rs422.dts => imx8mm-venice-gw72xx-0x-rs422.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw72xx-0x-rs485.dts => imx8mm-venice-gw72xx-0x-rs485.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw73xx-0x-imx219.dts => imx8mm-venice-gw73xx-0x-imx219.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw73xx-0x-rs232-rts.dts => imx8mm-venice-gw73xx-0x-rs232-rts.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw73xx-0x-rs422.dts => imx8mm-venice-gw73xx-0x-rs422.dtso} (100%)
>  rename arch/arm64/boot/dts/freescale/{imx8mm-venice-gw73xx-0x-rs485.dts => imx8mm-venice-gw73xx-0x-rs485.dtso} (100%)
>  rename arch/arm64/boot/dts/renesas/{draak-ebisu-panel-aa104xd12.dts => draak-ebisu-panel-aa104xd12.dtso} (100%)
>  rename arch/arm64/boot/dts/renesas/{salvator-panel-aa104xd12.dts => salvator-panel-aa104xd12.dtso} (100%)
>  rename arch/arm64/boot/dts/xilinx/{zynqmp-sck-kv-g-revA.dts => zynqmp-sck-kv-g-revA.dtso} (100%)
>  rename arch/arm64/boot/dts/xilinx/{zynqmp-sck-kv-g-revB.dts => zynqmp-sck-kv-g-revB.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay.dts => overlay.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_0.dts => overlay_0.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_1.dts => overlay_1.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_10.dts => overlay_10.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_11.dts => overlay_11.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_12.dts => overlay_12.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_13.dts => overlay_13.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_15.dts => overlay_15.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_16.dts => overlay_16.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_17.dts => overlay_17.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_18.dts => overlay_18.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_19.dts => overlay_19.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_2.dts => overlay_2.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_20.dts => overlay_20.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_3.dts => overlay_3.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_4.dts => overlay_4.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_5.dts => overlay_5.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_6.dts => overlay_6.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_7.dts => overlay_7.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_8.dts => overlay_8.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_9.dts => overlay_9.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_bad_add_dup_node.dts => overlay_bad_add_dup_node.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_bad_add_dup_prop.dts => overlay_bad_add_dup_prop.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_bad_phandle.dts => overlay_bad_phandle.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_bad_symbol.dts => overlay_bad_symbol.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_base.dts => overlay_base.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_gpio_01.dts => overlay_gpio_01.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_gpio_02a.dts => overlay_gpio_02a.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_gpio_02b.dts => overlay_gpio_02b.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_gpio_03.dts => overlay_gpio_03.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_gpio_04a.dts => overlay_gpio_04a.dtso} (100%)
>  rename drivers/of/unittest-data/{overlay_gpio_04b.dts => overlay_gpio_04b.dtso} (100%)
>  rename drivers/of/unittest-data/{testcases.dts => testcases.dtso} (100%)
>  rename drivers/staging/pi433/Documentation/devicetree/{pi433-overlay.dts => pi433-overlay.dtso} (100%)
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ