linux-kernel - Re: [driver-core:driver-core-testing] BUILD SUCCESS 59789f3418dd3c0a187490d49e900a59a5c8d732

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1ZZuY/cS/zePKTe@smile.fi.intel.com>
Date:   Mon, 24 Oct 2022 12:24:09 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Chen, Rong A" <rong.a.chen@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>
Subject: Re: [driver-core:driver-core-testing] BUILD SUCCESS
 59789f3418dd3c0a187490d49e900a59a5c8d732

On Mon, Oct 24, 2022 at 05:08:37PM +0800, Chen, Rong A wrote:
> On 10/24/2022 4:57 PM, Andy Shevchenko wrote:
> > On Mon, Oct 24, 2022 at 09:10:53AM +0800, Chen, Rong A wrote:
> > > On 10/24/2022 3:52 AM, Andy Shevchenko wrote:
> > > > On Sun, Oct 23, 2022 at 10:43:07PM +0300, Andy Shevchenko wrote:
> > > > > On Sun, Oct 23, 2022 at 02:33:40PM +0200, Greg Kroah-Hartman wrote:
> > > > > > On Sun, Oct 23, 2022 at 08:03:57AM +0800, kernel test robot wrote:
> > > > > > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
> > > > > > > branch HEAD: 59789f3418dd3c0a187490d49e900a59a5c8d732  device property: Constify parameter in device_dma_supported() and device_get_dma_attr()
> > > > > > > 
> > > > > > > Unverified Warning (likely false positive, please contact us if interested):
> > > > > > > 
> > > > > > > drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine type of argument 4
> > > > > > 
> > > > > > Andy, this is due to your changes, here's the offending code:
> > > > > > 
> > > > > > 	sname = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", dev_fwnode(dev));
> > > > > > 
> > > > > > Now that dev_fwnode() is an inline function, the compiler is confused as
> > > > > > to what function to select?  Maybe, I don't know, it seems odd, can you
> > > > > > look into it?
> > > > > 
> > > > > Hmm... I can't reproduce on my side.
> > > > > Any (additional) information about compiler, architecture, etc?
> > > > 
> > > > I found the original report, but I don't see how to extract the defconfig /
> > > > config it used. Can you send that file to me?
> > > > 
> > > 
> > > Hi Andy,
> > > 
> > > The original report can be found at https://lists.01.org/hyperkitty/list/kbuild@lists.01.org/thread/VE7CMY7FVIPYWHL4XMOCFWCNYTGZSTKP/
> > > 
> > > and config file can be downloaded from https://lists.01.org/hyperkitty/list/kbuild@lists.01.org/message/VE7CMY7FVIPYWHL4XMOCFWCNYTGZSTKP/attachment/2/config.ksh
> > 
> > Thanks!
> > 
> > Can't reproduce on my Debian (x86_64):
> > 
> > gcc (Debian 12.2.0-3) 12.2.0
> > Copyright (C) 2022 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions.  There is NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> > 
> > Is it GCC issue?
> > 
> > Any pointers where I can download the compiler you are using?
> > 
> 
> Hi Andy,
> 
> It's a smatch warning, it may be a false positive since Dan didn't forward
> the report. +Dan
> 
> smatch warnings:
> drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine
> type of argument 4

Ah, okay, pretty much looks like false positive due to smatch unable to handle
_Generic().

-- 
With Best Regards,
Andy Shevchenko